New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ldas-tools: Added pkgconfig as build dependency #20
Conversation
Please follow CommitRules for the commit message format. Put ticket links also into the commit message with full URLs. This will automatically add commit references to these tickets when the pull request is merged to master. If this pull request closes these tickets, please use appropriate keywords in front of them, for example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow CommitRules.
Updated the initial comment to address the change request |
This does not yet address my requests. I was talking about the commit message, not the comments on GitHub. You will need to edit the commit itself. Go to your local branch from which you started this pull request, edit the commit message, than overwrite the existing pull request. Assuming remote
|
…asgen, ldas-tools-frameAPI, ldas-tools-diskcacheAPI, ldas-tools-utilities: Fixes build dependency This addresses all 7 ldas-tools packages when needed pkgconfig added as a build dependency Closes: https://trac.macports.org/ticket/52799 Closes: https://trac.macports.org/ticket/52800 Closes: https://trac.macports.org/ticket/52801 Closes: https://trac.macports.org/ticket/52802 Closes: https://trac.macports.org/ticket/52803 Closes: https://trac.macports.org/ticket/52804 Closes: https://trac.macports.org/ticket/52805
8b51176
to
58793e1
Compare
Updated the commit comment. |
@larryv extended the wiki page on CommitMessages with more details while this pull request was open. I fixed your commit message to fit into 50 characters and wrapped the body at 72 characters. Thank you for the contribution. |
ldas-tools-al, ldas-tools-filters, ldas-tools-framecpp, ldas-tools-ldasgen, ldas-tools-frameAPI, ldas-tools-diskcacheAPI, ldas-tools-utilities: Fixes build dependency
This addresses all 7 ldas-tools packages when needed pkgconfig added as a build dependency
Closes: https://trac.macports.org/ticket/52799
Closes: https://trac.macports.org/ticket/52800
Closes: https://trac.macports.org/ticket/52801
Closes: https://trac.macports.org/ticket/52802
Closes: https://trac.macports.org/ticket/52803
Closes: https://trac.macports.org/ticket/52804
Closes: https://trac.macports.org/ticket/52805