openjdk11-graalvm: clean up old files before installation, install files under ${prefix}

[breun]

Description

• Clean up old files before installation. This should fix https://trac.macports.org/ticket/67935.
• Install all actual files under ${prefix}, only create a symlink under /Library/Java/JavaVirtualMachines.

Type(s)

• bugfix
• enhancement

Tested on

macOS 13.5.1 22G90 arm64
Xcode 14.3.1 14E300c

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[mascguy]

It looks like the native image subport is failing, due to the following:

/Library/Java/JavaVirtualMachines/openjdk11-graalvm/Contents/Home/bin/gu: command not found

[breun]

Hm, I don't really understand. openjdk11-graalvm installs /opt/local/Library/Java/JavaVirtualMachines/openjdk11-graalvm/Contents/Home/bin/gu and symlinks /Library/Java/JavaVirtualMachines/openjdk11-graalvm to /opt/local/Library/Java/JavaVirtualMachines/openjdk11-graalvm, so /Library/Java/JavaVirtualMachines/openjdk11-graalvm//Contents/Home/bin/gu should be there... And it is on my machine.

[breun]

Or should gu be called as ${prefix}${jdk}/Contents/Home/bin/gu in this context without relying on the symlink?

[breun]

Adding ${prefix} seems to help indeed. I'll fix up the PR.

[breun]

It looks like you're installing ARM binary for Intel, and vice-versa.

Hm, no that looks fine to me actually.

[mascguy]

It looks like you're installing ARM binary for Intel, and vice-versa.

Hm, no that looks fine to me actually.

Yep, my eyes are failing me again! Lol

I misread "amd64" as "arm64." Never Mind...

[breun]

All checks passed now.

[breun]

@mascguy I think we may have introduced a new issue with the pre-install block.

After installing sudo port install openjdk11-graalvm, everything seems fine. ls -l /Library/Java/JavaVirtualMachines shows that /Library/Java/JavaVirtualMachines/openjdk11-graalvm is a symlink to /opt/local/Library/Java/JavaVirtualMachines/openjdk11-graalvm.

But when you subsequently install openjdk11-graalvm-native-image, /Library/Java/JavaVirtualMachines/openjdk11-graalvm is gone. I guess pre-install also gets executed for the openjdk11-graalvm-native-image subport.

It looks like stuff like variants are also applied to the subport, which also shouldn't be happening. How can I make sure that particular sections only get applied for the main port?

[mascguy]

@mascguy I think we may have introduced a new issue with the pre-install block.

After installing sudo port install openjdk11-graalvm, everything seems fine. ls -l /Library/Java/JavaVirtualMachines shows that /Library/Java/JavaVirtualMachines/openjdk11-graalvm is a symlink to /opt/local/Library/Java/JavaVirtualMachines/openjdk11-graalvm.

But when you subsequently install openjdk11-graalvm-native-image, /Library/Java/JavaVirtualMachines/openjdk11-graalvm is gone. I guess pre-install also gets executed for the openjdk11-graalvm-native-image subport.

It looks like stuff like variants are also applied to the subport, which also shouldn't be happening. How can I make sure that particular sections only get applied for the main port?

Ensure your pre-install block is only defined for your main port, like so:

if { ${subport} eq ${name} } {
    pre-install {
        [...]
    }
}

[mascguy]

Ensure your pre-install block is only defined for your main port, like so:

if { ${subport} eq ${name} } {
    pre-install {
        [...]
    }
}

And also add your variants, etc, in that block [if they're only desired for the main port].

[breun]

Check, new PR for that: #20045