ldid-procursus: new port

[TheRealKeto]

Description

ldid-procursus is a fork of the original ldid project, with extensions that enhance the original behavior of several options. Maintained by the Procursus Team, this fork is open to contributions, becoming "mainstream" in the jailbreaking community - where the original project shines - while working around the fact that the original creator does not accept contributions.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 12.6 21G115 arm64
Xcode 14.2 14C18

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[TheRealKeto]

All changes have been resolved and implemented. All new changes will be pushed shortly. The workflow might need to be approved again.

[herbygillot]

@TheRealKeto, thank you for this submission, and @catap thank you for your help and time reviewing this so far.

This looks good, only comment I would have is that it's fine to install completions by default, whether zsh is installed or not. Variants require folks to be aware of them, and for better or worse most folks just install ports using the default variants.

So I would say remove the variant and have the same post-destroot block just part of the main Portfile. Remove the explicit depends_run reference for zsh. Those who have zsh installed get the completions automatically and those who don't aren't really affected either way.

[pmetzger]

Strongly agreed. We've had a policy of always installing completions for some time now.

[catap]

@pmetzger, @herbygillot maybe remove variants to prevent confusion?

(I mean from the other ports)

[herbygillot]

@pmetzger, @herbygillot maybe remove variants to prevent confusion?

(I mean from the other ports)

Probably the right thing to do as part of routine updates to these ports over time. (Specifically version updates.)

[TheRealKeto]

@herbygillot I've removed the variant. Workflow might need further approval.

[herbygillot]

@herbygillot I've removed the variant. Workflow might need further approval.

Looks good. One last comment above.

[pmetzger]

maybe remove variants to prevent confusion?
(I mean from the other ports)

Long term, as part of maintenance, yes. If someone wants to undertake a project it might be fine but it's not necessary.

[herbygillot]

platforms darwin is implicit in MacPorts now, so that line can be dropped, but we'll merge this for now.

[herbygillot]

Thanks for your contribution @TheRealKeto.