Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InsightToolkit: new port InsightToolkit version 5.3.0, replacing InsightToolkit-devel #20399

Merged
merged 2 commits into from
Sep 24, 2023

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Sep 12, 2023

Description

Create new port InsightToolkit 5.3.0, replacing InsightToolkit-devel. Also add Python subports, along with general Portfile overhaul.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.6.6 21G646 arm64
Xcode 14.2 14C18

Verification

Have you

@macportsbot
Copy link

Notifying maintainers:
@stromnov for port InsightToolkit-devel.

@nilason nilason force-pushed the itk_upd branch 2 times, most recently from 32434d9 to d4ed445 Compare September 12, 2023 10:34
@nilason nilason changed the title InsightToolkit[-devel,4]: update to 5.3 and new port pinned on v4 InsightToolkit-devel: update to version 5.3.0 Sep 12, 2023
@nilason
Copy link
Contributor Author

nilason commented Sep 12, 2023

The CI's weren't happy with two conflicting ports, I moved part of this original PR to #20400.

@nilason
Copy link
Contributor Author

nilason commented Sep 14, 2023

This depends on merging #20424 .

@mascguy
Copy link
Member

mascguy commented Sep 22, 2023

It might also be worth dropping the Python 3.9 subport, for both InsightToolkit ports.

@nilason
Copy link
Contributor Author

nilason commented Sep 22, 2023

It might also be worth dropping the Python 3.9 subport, for both InsightToolkit ports.

I wouldn't mind. Will do.

I also plan to add to this PR, a port rename. From InsightToolkit-devel to just InsightToolkit (in the process making the former obsolete). Any thoughts on that?

@mascguy
Copy link
Member

mascguy commented Sep 22, 2023

I also plan to add to this PR, a port rename. From InsightToolkit-devel to just InsightToolkit (in the process making the former obsolete). Any thoughts on that?

Seems reasonable.

Do you expect this port to remain at major version 5.x? Or is the plan to keep this in-sync with upstream, including updating beyond to 6.x, etc?

@nilason
Copy link
Contributor Author

nilason commented Sep 22, 2023

I also plan to add to this PR, a port rename. From InsightToolkit-devel to just InsightToolkit (in the process making the former obsolete). Any thoughts on that?

Seems reasonable.

Do you expect this port to remain at major version 5.x? Or is the plan to keep this in-sync with upstream, including updating beyond to 6.x, etc?

My plan is to keep InsightToolkit the latest version available (to continue with 6.x etc). If necessary – for whatever reason (like the need for InsightToolkit4 for the orfeotoolbox update) – fork and create a InsightToolkit5 and so forth.

@mascguy
Copy link
Member

mascguy commented Sep 22, 2023

My plan is to keep InsightToolkit the latest version available (to continue with 6.x etc). If necessary – for whatever reason (like the need for InsightToolkit4 for the orfeotoolbox update) – fork and create a InsightToolkit5 and so forth.

Sounds great!

@nilason
Copy link
Contributor Author

nilason commented Sep 23, 2023

I addressed the issues you had. I also changed this to create a new port InsightToolkit and make InsightToolkit-devel obsolete. I added myself as co-maintainer for InsightToolkit.

Has there ever been a port named InsightToolkit and if so, did it have epoch set?

@nilason nilason changed the title InsightToolkit-devel: update to version 5.3.0 InsightToolkit{-devel}: new port with version 5.3.0, make InsightToolkit-devel obsolete Sep 23, 2023
@nilason nilason changed the title InsightToolkit{-devel}: new port with version 5.3.0, make InsightToolkit-devel obsolete InsightToolkit{-devel}: new port InsightToolkit version 5.3.0, replacing InsightToolkit-devel Sep 23, 2023
@mascguy
Copy link
Member

mascguy commented Sep 23, 2023

I addressed the issues you had. I also changed this to create a new port InsightToolkit and make InsightToolkit-devel obsolete. I added myself as co-maintainer for InsightToolkit.

Has there ever been a port named InsightToolkit and if so, did it have epoch set?

There was at one point, but the last version was 3.16.0. And no, epoch was not set.

Copy link
Member

@mascguy mascguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from obsolete date needed for InsightToolkit-devel.

@nilason nilason marked this pull request as ready for review September 23, 2023 18:56
@nilason
Copy link
Contributor Author

nilason commented Sep 23, 2023

Obsolete date added.

@nilason
Copy link
Contributor Author

nilason commented Sep 23, 2023

I addressed the issues you had. I also changed this to create a new port InsightToolkit and make InsightToolkit-devel obsolete. I added myself as co-maintainer for InsightToolkit.
Has there ever been a port named InsightToolkit and if so, did it have epoch set?

There was at one point, but the last version was 3.16.0. And no, epoch was not set.

That explains the "-devel" port for v4+ I suppose.

@mascguy mascguy changed the title InsightToolkit{-devel}: new port InsightToolkit version 5.3.0, replacing InsightToolkit-devel InsightToolkit: new port InsightToolkit version 5.3.0, replacing InsightToolkit-devel Sep 23, 2023
@mascguy mascguy merged commit 816964e into macports:master Sep 24, 2023
2 of 3 checks passed
@nilason
Copy link
Contributor Author

nilason commented Sep 24, 2023

Thanks for your assistance!

@nilason nilason deleted the itk_upd branch October 5, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants