-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InsightToolkit: new port InsightToolkit version 5.3.0, replacing InsightToolkit-devel #20399
Conversation
Notifying maintainers: |
32434d9
to
d4ed445
Compare
The CI's weren't happy with two conflicting ports, I moved part of this original PR to #20400. |
0562e6d
to
6fdcb40
Compare
This depends on merging #20424 . |
It might also be worth dropping the Python 3.9 subport, for both InsightToolkit ports. |
I wouldn't mind. Will do. I also plan to add to this PR, a port rename. From |
Seems reasonable. Do you expect this port to remain at major version 5.x? Or is the plan to keep this in-sync with upstream, including updating beyond to 6.x, etc? |
My plan is to keep |
Sounds great! |
I addressed the issues you had. I also changed this to create a new port Has there ever been a port named |
There was at one point, but the last version was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from obsolete date needed for InsightToolkit-devel
.
Obsolete date added. |
That explains the "-devel" port for v4+ I suppose. |
Thanks for your assistance! |
Description
Create new port
InsightToolkit
5.3.0, replacingInsightToolkit-devel
. Also add Python subports, along with general Portfile overhaul.Type(s)
Tested on
macOS 12.6.6 21G646 arm64
Xcode 14.2 14C18
Verification
Have you
port lint --nitpick
?sudo port -vst install
?