Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv: update to 1.46.0 #20421

Closed
wants to merge 1 commit into from
Closed

Conversation

herbygillot
Copy link
Member

Does not look like revbumping dependent ports is needed as library path & name haven't changed.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test? (Output below)
  • tried a full install with sudo port -vst install sudo port -d destroot?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?
Test Output
1..427
ok 1 - platform_output
# Output from process `platform_output`:
# uv_get_process_title: /opt/macports-test/var/macports/build/_Users_herby_Source_macports-ports_devel_libuv/libuv/work/libuv-1.46.0/test/.libs/run-tests
# uv_cwd: /opt/macports-test/var/macports/build/_Users_herby_Source_macports-ports_devel_libuv/libuv/work/libuv-1.46.0
# uv_resident_set_memory: 1458176
# uv_uptime: 461199.000000
# uv_getrusage:
#   user: 0 sec 1298 microsec
#   system: 0 sec 865 microsec
#   page faults: 3
#   maximum resident set size: 1424
# uv_available_parallelism: 10
# uv_cpu_info:
#   model: Apple M1 Max
#   speed: 2400
#   times.sys: 32233020
#   times.user: 54284770
#   times.idle: 148961380
#   times.irq: 0
#   times.nice: 0
#   model: Apple M1 Max
#   speed: 2400
#   times.sys: 30793360
#   times.user: 53978850
#   times.idle: 150757280
#   times.irq: 0
#   times.nice: 0
#   model: Apple M1 Max
#   speed: 2400
#   times.sys: 11844480
#   times.user: 30315990
#   times.idle: 193622350
#   times.irq: 0
#   times.nice: 0
#   model: Apple M1 Max
#   speed: 2400
#   times.sys: 7390510
#   times.user: 21182480
#   times.idle: 207498700
#   times.irq: 0
#   times
# .nice: 0
#   model: Apple M1 Max
#   speed: 2400
#   times.sys: 4022900
#   times.user: 14074120
#   times.idle: 218165660
#   times.irq: 0
#   times.nice: 0
#   model: Apple M1 Max
#   speed: 2400
#   times.sys: 2885100
#   times.user: 11297330
#   times.idle: 222161860
#   times.irq: 0
#   times.nice: 0
#   model: Apple M1 Max
#   speed: 2400
#   times.sys: 3645710
#   times.user: 13457290
#   times.idle: 219282680
#   times.irq: 0
#   times.nice: 0
#   model: Apple M1 Max
#   speed: 2400
#   times.sys: 1548980
#   times.user: 8133080
#   times.idle: 226806270
#   times.irq: 0
#   times.nice: 0
#   model: Apple M1 Max
#   speed: 2400
#   times.sys: 962980
#   times.user: 6221930
#   times.idle: 229362960
#   times.irq: 0
#   times.nice: 0
#   model: Apple M1 Max
#   speed: 2400
#   times.sys: 740080
#   times.user: 5396520
#   times.idle: 230430920
#   times.irq: 0
#   times.nice: 0
# uv_interface_addresses:
#   name: lo0
#   internal: 1
#   physical address: 00:00:00:00:00:00
#   address: 127.0.0.1
#   netmask: 255.0.0.0
#   name: lo0
#   internal: 1
#   physical address: 00:00:00:00:00:00
#   address: ::1
#  
#  netmask: ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff
#   name: lo0
#   internal: 1
#   physical address: 00:00:00:00:00:00
#   address: fe80::1
#   netmask: ffff:ffff:ffff:ffff::
#   name: anpi0
#   internal: 0
#   physical address: 66:39:d7:94:33:e8
#   address: fe80::6439:d7ff:fe94:33e8
#   netmask: ffff:ffff:ffff:ffff::
#   name: anpi2
#   internal: 0
#   physical address: 66:39:d7:94:33:ea
#   address: fe80::6439:d7ff:fe94:33ea
#   netmask: ffff:ffff:ffff:ffff::
#   name: anpi1
#   internal: 0
#   physical address: 66:39:d7:94:33:e9
#   address: fe80::6439:d7ff:fe94:33e9
#   netmask: ffff:ffff:ffff:ffff::
#   name: ap1
#   internal: 0
#   physical address: f6:d4:88:64:6a:a2
#   address: fe80::f4d4:88ff:fe64:6aa2
#   netmask: ffff:ffff:ffff:ffff::
#   name: en0
#   internal: 0
#   physical address: f4:d4:88:64:6a:a2
#   address: fe80::14cd:65f4:6316:a46
#   netmask: ffff:ffff:ffff:ffff::
#   name: en0
#   internal: 0
#   physical address: f4:d4:88:64:6a:a2
#   address: 192.168.1.184
#   netmask: 255.255.255.0
#   name: en0
#   internal: 0
#   physical address: f4:d4:88:64:6a:a2
#   add
# ress: 2600:4041:5b98:d400:14aa:2a4d:1607:dd19
#   netmask: ffff:ffff:ffff:ffff::
#   name: en0
#   internal: 0
#   physical address: f4:d4:88:64:6a:a2
#   address: 2600:4041:5b98:d400:955e:7e2e:f90d:d151
#   netmask: ffff:ffff:ffff:ffff::
#   name: en0
#   internal: 0
#   physical address: f4:d4:88:64:6a:a2
#   address: 2600:4041:5b98:d400:c76:c3e6:6387:39f0
#   netmask: ffff:ffff:ffff:ffff::
#   name: awdl0
#   internal: 0
#   physical address: ba:1d:0a:71:f9:ec
#   address: fe80::b81d:aff:fe71:f9ec
#   netmask: ffff:ffff:ffff:ffff::
#   name: llw0
#   internal: 0
#   physical address: ba:1d:0a:71:f9:ec
#   address: fe80::b81d:aff:fe71:f9ec
#   netmask: ffff:ffff:ffff:ffff::
#   name: utun0
#   internal: 0
#   physical address: 00:00:00:00:00:00
#   address: fe80::4daf:4e6a:ae9c:2558
#   netmask: ffff:ffff:ffff:ffff::
#   name: utun1
#   internal: 0
#   physical address: 00:00:00:00:00:00
#   address: fe80::12cd:c624:640e:799a
#   netmask: ffff:ffff:ffff:ffff::
#   name: utun2
#   internal: 0
#   physical address: 00:00:00:00:00:00
#   address: fe80::ce81:b1c:bd2c:69e
#   netmas
# k: ffff:ffff:ffff:ffff::
# uv_os_get_passwd:
#   euid: 502
#   gid: 501 (macports)
#     members: [ ]
#   username: macports
#   shell: /usr/bin/false
#   home directory: /opt/local/var/macports/home
# uv_os_getpid: 59436
# uv_os_getppid: 59422
# uv_os_uname:
#   sysname: Darwin
#   release: 22.6.0
#   version: Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000
#   machine: arm64
ok 2 - active
ok 3 - async
ok 4 - async_null_cb
ok 5 - async_ref
ok 6 - barrier_1
ok 7 - barrier_2
ok 8 - barrier_3
ok 9 - barrier_serial_thread
ok 10 - barrier_serial_thread_single
ok 11 - callback_stack
ok 12 - check_ref
ok 13 - clock_gettime
ok 14 - close_fd
ok 15 - close_order
ok 16 - closed_fd_events
ok 17 - condvar_1
ok 18 - condvar_2
ok 19 - condvar_3
ok 20 - condvar_4
ok 21 - condvar_5
ok 22 - connect_unspecified
ok 23 - connection_fail
ok 24 - connection_fail_doesnt_auto_close
ok 25 - cwd_and_chdir
ok 26 - default_loop_close
ok 27 - delayed_accept
ok 28 - dlerror
ok 29 - eintr_handling
ok 30 - embed
ok 31 - emfile
ok 32 - env_vars
ok 33 - error_message
ok 34 - fork_signal_to_child
ok 35 - fork_signal_to_child_closed
ok 36 - fork_socketpair
ok 37 - fork_socketpair_started
ok 38 - fork_threadpool_queue_work_simple
ok 39 - fork_timer
ok 40 - fs_access
ok 41 - fs_async_dir
ok 42 - fs_async_sendfile
ok 43 - fs_async_sendfile_nodata
ok 44 - fs_chmod
ok 45 - fs_chown
ok 46 - fs_copyfile
ok 47 - fs_event_close_in_callback
ok 48 - fs_event_close_with_pending_delete_event
ok 49 - fs_event_close_with_pending_event
ok 50 - fs_event_error_reporting
ok 51 - fs_event_getpath
ok 52 - fs_event_immediate_close
ok 53 - fs_event_no_callback_after_close
ok 54 - fs_event_no_callback_on_close
ok 55 - fs_event_ref
ok 56 - fs_event_start_and_close
ok 57 - fs_event_stop_in_cb
ok 58 - fs_event_watch_dir
ok 59 - fs_event_watch_dir_recursive
ok 60 - fs_event_watch_file
ok 61 - fs_event_watch_file_current_dir
ok 62 - fs_event_watch_file_exact_path
ok 63 - fs_event_watch_file_twice
ok 64 - fs_event_watch_invalid_path
ok 65 - fs_file_async
ok 66 - fs_file_loop
ok 67 - fs_file_nametoolong
ok 68 - fs_file_noent
ok 69 - fs_file_open_append
ok 70 - fs_file_pos_after_op_with_offset
ok 71 - fs_file_sync
ok 72 - fs_file_write_null_buffer
ok 73 - fs_fstat
ok 74 - fs_fstat_stdio
ok 75 - fs_futime
ok 76 - fs_get_system_error
ok 77 - fs_lutime
ok 78 - fs_mkdtemp
ok 79 - fs_mkstemp
ok 80 - fs_null_req
ok 81 - fs_open_dir
ok 82 - fs_partial_read
ok 83 - fs_partial_write
ok 84 - fs_poll
ok 85 - fs_poll_close_request
ok 86 - fs_poll_close_request_multi_start_stop
ok 87 - fs_poll_close_request_multi_stop_start
ok 88 - fs_poll_close_request_stop_when_active
ok 89 - fs_poll_getpath
ok 90 - fs_poll_ref
ok 91 - fs_read_bufs
ok 92 - fs_read_dir
ok 93 - fs_read_file_eof
ok 94 - fs_read_write_null_arguments
ok 95 - fs_readdir_empty_dir
ok 96 - fs_readdir_file
ok 97 - fs_readdir_non_empty_dir
ok 98 - fs_readdir_non_existing_dir
ok 99 - fs_readlink
ok 100 - fs_realpath
ok 101 - fs_rename_to_existing_file
ok 102 - fs_scandir_early_exit
ok 103 - fs_scandir_empty_dir
ok 104 - fs_scandir_file
ok 105 - fs_scandir_non_existent_dir
ok 106 - fs_stat_batch_multiple
ok 107 - fs_stat_missing_path
ok 108 - fs_statfs
ok 109 - fs_symlink
ok 110 - fs_symlink_dir
ok 111 - fs_unlink_readonly
ok 112 - fs_utime
ok 113 - fs_utime_round
ok 114 - fs_write_alotof_bufs
ok 115 - fs_write_alotof_bufs_with_offset
ok 116 - fs_write_multiple_bufs
ok 117 - get_currentexe
ok 118 - get_group
ok 119 - get_loadavg
ok 120 - get_memory
ok 121 - get_osfhandle_valid_handle
ok 122 - get_passwd
ok 123 - get_passwd2
ok 124 - getaddrinfo_basic
ok 125 - getaddrinfo_basic_sync
ok 126 - getaddrinfo_concurrent
ok 127 - getaddrinfo_fail
ok 128 - getaddrinfo_fail_sync
ok 129 - gethostname
ok 130 - getnameinfo_basic_ip4
ok 131 - getnameinfo_basic_ip4_sync
ok 132 - getnameinfo_basic_ip6
ok 133 - getsockname_tcp
ok 134 - getsockname_udp
ok 135 - getters_setters
ok 136 - gettimeofday
ok 137 - handle_fileno
ok 138 - handle_type_name
ok 139 - has_ref
ok 140 - homedir
ok 141 - hrtime
ok 142 - idle_check
ok 143 - idle_ref
ok 144 - idle_starvation
ok 145 - idna_toascii
ok 146 - ip4_addr
ok 147 - ip6_addr_link_local
ok 148 - ip6_pton
ok 149 - ip6_sin6_len
ok 150 - ip_name
ok 151 - ipc_heavy_traffic_deadlock_bug
ok 152 - ipc_listen_after_write
ok 153 - ipc_listen_before_write
ok 154 - ipc_send_recv_pipe
ok 155 - ipc_send_recv_pipe_inprocess
ok 156 - ipc_send_recv_tcp
ok 157 - ipc_send_recv_tcp_inprocess
ok 158 - ipc_send_zero
ok 159 - ipc_tcp_connection
ok 160 - kill
ok 161 - kill_invalid_signum
ok 162 - loop_alive
ok 163 - loop_backend_timeout
ok 164 - loop_close
ok 165 - loop_configure
ok 166 - loop_handles
ok 167 - loop_instant_close
ok 168 - loop_stop
ok 169 - loop_stop_before_run
ok 170 - loop_update_time
ok 171 - metrics_idle_time
ok 172 - metrics_idle_time_thread
ok 173 - metrics_idle_time_zero
ok 174 - metrics_info_check
ok 175 - metrics_pool_events
ok 176 - multiple_listen
ok 177 - not_readable_nor_writable_on_read_error
ok 178 - not_writable_after_shutdown
ok 179 - open_osfhandle_valid_handle
ok 180 - osx_select
ok 181 - osx_select_many_fds
ok 182 - pipe_bind_error_addrinuse
ok 183 - pipe_bind_error_addrnotavail
ok 184 - pipe_bind_error_inval
ok 185 - pipe_bind_or_listen_error_after_close
ok 186 - pipe_close_stdout_read_stdin
ok 187 - pipe_connect_bad_name
ok 188 - pipe_connect_close_multiple
ok 189 - pipe_connect_multiple
ok 190 - pipe_connect_on_prepare
ok 191 - pipe_connect_to_file
ok 192 - pipe_getsockname
ok 193 - pipe_getsockname_abstract
ok 194 - pipe_getsockname_blocking
ok 195 - pipe_listen_without_bind
ok 196 - pipe_overlong_path
ok 197 - pipe_pending_instances
ok 198 - pipe_ping_pong
ok 199 - pipe_ping_pong_vec
ok 200 - pipe_ref
ok 201 - pipe_ref2
ok 202 - pipe_ref3
ok 203 - pipe_ref4
ok 204 - pipe_sendmsg
ok 205 - pipe_server_close
ok 206 - pipe_set_chmod
ok 207 - pipe_set_non_blocking
ok 208 - poll_bad_fdtype
ok 209 - poll_close
ok 210 - poll_close_doesnt_corrupt_stack # SKIP Test only relevant on Windows
ok 211 - poll_closesocket # SKIP Test only relevant on Windows
ok 212 - poll_duplex
ok 213 - poll_multiple_handles
ok 214 - poll_nested_kqueue
ok 215 - poll_oob
ok 216 - poll_unidirectional
ok 217 - prepare_ref
ok 218 - process_priority
ok 219 - process_ref
ok 220 - process_title
ok 221 - process_title_big_argv
ok 222 - process_title_threadsafe
ok 223 - queue_foreach_delete
ok 224 - random_async
ok 225 - random_sync
ok 226 - readable_on_eof
ok 227 - ref
ok 228 - req_type_name
ok 229 - run_nowait
ok 230 - run_once
ok 231 - semaphore_1
ok 232 - semaphore_2
ok 233 - semaphore_3
ok 234 - shutdown_close_pipe
ok 235 - shutdown_close_tcp
ok 236 - shutdown_eof
ok 237 - shutdown_simultaneous
ok 238 - shutdown_twice
ok 239 - signal_close_loop_alive
ok 240 - signal_multiple_loops
ok 241 - signal_pending_on_close
ok 242 - socket_buffer_size
ok 243 - spawn_and_kill
ok 244 - spawn_and_kill_with_std
ok 245 - spawn_and_ping
ok 246 - spawn_auto_unref
ok 247 - spawn_closed_process_io
ok 248 - spawn_detached
ok 249 - spawn_empty_env # SKIP doesn't work with DYLD_LIBRARY_PATH/LD_LIBRARY_PATH/LIBPATH
ok 250 - spawn_exercise_sigchld_issue
ok 251 - spawn_exit_code
ok 252 - spawn_fails
ok 253 - spawn_fails_check_for_waitpid_cleanup
ok 254 - spawn_fs_open
ok 255 - spawn_ignored_stdio
ok 256 - spawn_inherit_streams
ok 257 - spawn_preserve_env
ok 258 - spawn_quoted_path # SKIP Test for Windows
ok 259 - spawn_reads_child_path
ok 260 - spawn_relative_path
ok 261 - spawn_setgid_fails
ok 262 - spawn_setuid_fails
ok 263 - spawn_setuid_setgid # SKIP It should be run as root user
ok 264 - spawn_stdin
ok 265 - spawn_stdio_greater_than_3
ok 266 - spawn_stdout
ok 267 - spawn_stdout_and_stderr_to_file
ok 268 - spawn_stdout_and_stderr_to_file2
ok 269 - spawn_stdout_and_stderr_to_file_swap
ok 270 - spawn_stdout_to_file
ok 271 - spawn_tcp_server
ok 272 - stdio_emulate_iocp
ok 273 - stdio_over_pipes
ok 274 - strscpy
ok 275 - strtok
ok 276 - sys_error
ok 277 - tcp6_local_connect_timeout
ok 278 - tcp6_ping_pong
ok 279 - tcp6_ping_pong_vec
ok 280 - tcp_alloc_cb_fail
ok 281 - tcp_bind6_error_addrinuse
ok 282 - tcp_bind6_error_addrnotavail
ok 283 - tcp_bind6_error_fault
ok 284 - tcp_bind6_error_inval
ok 285 - tcp_bind6_localhost_ok
ok 286 - tcp_bind_error_addrinuse_connect
ok 287 - tcp_bind_error_addrinuse_listen
ok 288 - tcp_bind_error_addrnotavail_1
ok 289 - tcp_bind_error_addrnotavail_2
ok 290 - tcp_bind_error_fault
ok 291 - tcp_bind_error_inval
ok 292 - tcp_bind_invalid_flags
ok 293 - tcp_bind_localhost_ok
ok 294 - tcp_bind_or_listen_error_after_close
ok 295 - tcp_bind_writable_flags
ok 296 - tcp_close
ok 297 - tcp_close_accept
ok 298 - tcp_close_after_read_timeout
ok 299 - tcp_close_reset_accepted
ok 300 - tcp_close_reset_accepted_after_shutdown
ok 301 - tcp_close_reset_accepted_after_socket_shutdown
ok 302 - tcp_close_reset_client
ok 303 - tcp_close_reset_client_after_shutdown
ok 304 - tcp_close_while_connecting
ok 305 - tcp_connect_error_after_write
ok 306 - tcp_connect_error_fault
ok 307 - tcp_connect_timeout
ok 308 - tcp_create_early
ok 309 - tcp_create_early_accept
ok 310 - tcp_create_early_bad_bind
ok 311 - tcp_create_early_bad_domain
ok 312 - tcp_flags
ok 313 - tcp_listen_without_bind
ok 314 - tcp_local_connect_timeout
ok 315 - tcp_oob
ok 316 - tcp_open
ok 317 - tcp_open_bound
ok 318 - tcp_open_connected
ok 319 - tcp_open_twice
ok 320 - tcp_ping_pong
ok 321 - tcp_ping_pong_vec
ok 322 - tcp_read_stop
ok 323 - tcp_read_stop_start
ok 324 - tcp_ref
ok 325 - tcp_ref2
ok 326 - tcp_ref2b
ok 327 - tcp_ref3
ok 328 - tcp_ref4
ok 329 - tcp_rst
ok 330 - tcp_shutdown_after_write
ok 331 - tcp_try_write
ok 332 - tcp_try_write_error
ok 333 - tcp_unexpected_read
ok 334 - tcp_write_after_connect
ok 335 - tcp_write_fail
ok 336 - tcp_write_in_a_row
ok 337 - tcp_write_queue_order
ok 338 - tcp_write_ready
ok 339 - tcp_write_to_half_open_connection
ok 340 - tcp_writealot
ok 341 - test_macros
ok 342 - thread_affinity
ok 343 - thread_create
ok 344 - thread_equal
ok 345 - thread_local_storage
ok 346 - thread_mutex
ok 347 - thread_mutex_recursive
ok 348 - thread_rwlock
ok 349 - thread_rwlock_trylock
ok 350 - thread_stack_size
ok 351 - thread_stack_size_explicit
ok 352 - threadpool_cancel_fs
ok 353 - threadpool_cancel_getaddrinfo
ok 354 - threadpool_cancel_getnameinfo
ok 355 - threadpool_cancel_random
ok 356 - threadpool_cancel_single
ok 357 - threadpool_cancel_when_busy
ok 358 - threadpool_cancel_work
ok 359 - threadpool_multiple_event_loops
ok 360 - threadpool_queue_work_einval
ok 361 - threadpool_queue_work_simple
ok 362 - timer
ok 363 - timer_again
ok 364 - timer_early_check
ok 365 - timer_from_check
ok 366 - timer_huge_repeat
ok 367 - timer_huge_timeout
ok 368 - timer_init
ok 369 - timer_is_closing
ok 370 - timer_no_double_call_nowait
ok 371 - timer_no_double_call_once
ok 372 - timer_no_run_on_unref
ok 373 - timer_null_callback
ok 374 - timer_order
ok 375 - timer_ref
ok 376 - timer_ref2
ok 377 - timer_run_once
ok 378 - timer_start_twice
ok 379 - tmpdir
ok 380 - tty
ok 381 - tty_file
ok 382 - tty_pty
ok 383 - udp_alloc_cb_fail
ok 384 - udp_bind
ok 385 - udp_bind_reuseaddr
ok 386 - udp_connect
ok 387 - udp_connect6
ok 388 - udp_create_early
ok 389 - udp_create_early_bad_bind
ok 390 - udp_create_early_bad_domain
ok 391 - udp_dgram_too_big
ok 392 - udp_dual_stack
ok 393 - udp_ipv6_only
ok 394 - udp_mmsg
ok 395 - udp_multicast_interface
ok 396 - udp_multicast_interface6
ok 397 - udp_multicast_join
ok 398 - udp_multicast_join6
ok 399 - udp_multicast_ttl
ok 400 - udp_no_autobind
ok 401 - udp_open
ok 402 - udp_open_bound
ok 403 - udp_open_connect
ok 404 - udp_open_twice
ok 405 - udp_options
ok 406 - udp_options6
ok 407 - udp_recv_in_a_row
ok 408 - udp_ref
ok 409 - udp_ref2
ok 410 - udp_ref3
ok 411 - udp_send_and_recv
ok 412 - udp_send_hang_loop
ok 413 - udp_send_immediate
ok 414 - udp_send_unix
ok 415 - udp_send_unreachable
ok 416 - udp_sendmmsg_error
ok 417 - udp_try_send
ok 418 - uname
ok 419 - unref_in_prepare_cb
ok 420 - utf8_decode1
ok 421 - utf8_decode1_overrun
ok 422 - walk_handles
ok 423 - watcher_cross_stop
ok 424 - we_get_signal
ok 425 - we_get_signal_one_shot
ok 426 - we_get_signals
ok 427 - we_get_signals_mixed
PASS: test/run-tests
=============
1 test passed
=============

@macportsbot
Copy link

Notifying maintainers:
@michaelld for port libuv.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Sep 14, 2023
@herbygillot
Copy link
Member Author

P. S. Did the libuv upstream finally merge our legacy patches?

I just took another look, I think I need to revise this.

@herbygillot herbygillot marked this pull request as draft September 18, 2023 19:37
@herbygillot
Copy link
Member Author

herbygillot commented Oct 27, 2023

Ok, I've confirmed that the legacy patch is no longer needed in libuv 1.46.0.

I think the best way to proceed here is to check in a libuv-devel port to see how it builds across all the buildbots.

I have a PR open for this here: #21114

@casr casr mentioned this pull request Nov 11, 2023
10 tasks
@kencu
Copy link
Contributor

kencu commented Nov 11, 2023

Test suite does not want to run for me:

libtool: link: /opt/local/bin/gcc-mp-13 -fno-strict-aliasing -g -std=gnu89 -Wall -Wextra -Wno-long-long -Wno-unused-parameter -Wstrict-prototypes -pipe -Os -arch ppc -fvisibility=hidden -Wl,-headerpad_max_install_names -arch ppc -o test/.libs/run-tests test/run_tests-blackhole-server.o test/run_tests-echo-server.o test/run_tests-run-tests.o test/run_tests-runner.o test/run_tests-test-active.o test/run_tests-test-async.o test/run_tests-test-async-null-cb.o test/run_tests-test-barrier.o test/run_tests-test-callback-stack.o test/run_tests-test-close-fd.o test/run_tests-test-close-order.o test/run_tests-test-condvar.o test/run_tests-test-connect-unspecified.o test/run_tests-test-connection-fail.o test/run_tests-test-cwd-and-chdir.o test/run_tests-test-default-loop-close.o test/run_tests-test-delayed-accept.o test/run_tests-test-dlerror.o test/run_tests-test-eintr-handling.o test/run_tests-test-embed.o test/run_tests-test-emfile.o test/run_tests-test-env-vars.o test/run_tests-test-error.o test/run_tests-test-fail-always.o test/run_tests-test-fs-copyfile.o test/run_tests-test-fs-event.o test/run_tests-test-fs-poll.o test/run_tests-test-fs.o test/run_tests-test-fs-readdir.o test/run_tests-test-fs-fd-hash.o test/run_tests-test-fs-open-flags.o test/run_tests-test-fork.o test/run_tests-test-getters-setters.o test/run_tests-test-get-currentexe.o test/run_tests-test-get-loadavg.o test/run_tests-test-get-memory.o test/run_tests-test-get-passwd.o test/run_tests-test-getaddrinfo.o test/run_tests-test-gethostname.o test/run_tests-test-getnameinfo.o test/run_tests-test-getsockname.o test/run_tests-test-gettimeofday.o test/run_tests-test-handle-fileno.o test/run_tests-test-homedir.o test/run_tests-test-hrtime.o test/run_tests-test-idle.o test/run_tests-test-idna.o test/run_tests-test-ip4-addr.o test/run_tests-test-ip6-addr.o test/run_tests-test-ip-name.o test/run_tests-test-ipc-heavy-traffic-deadlock-bug.o test/run_tests-test-ipc-send-recv.o test/run_tests-test-ipc.o test/run_tests-test-loop-handles.o test/run_tests-test-loop-alive.o test/run_tests-test-loop-close.o test/run_tests-test-loop-stop.o test/run_tests-test-loop-time.o test/run_tests-test-loop-configure.o test/run_tests-test-metrics.o test/run_tests-test-multiple-listen.o test/run_tests-test-mutexes.o test/run_tests-test-not-readable-nor-writable-on-read-error.o test/run_tests-test-not-writable-after-shutdown.o test/run_tests-test-osx-select.o test/run_tests-test-pass-always.o test/run_tests-test-ping-pong.o test/run_tests-test-pipe-bind-error.o test/run_tests-test-pipe-connect-error.o test/run_tests-test-pipe-connect-multiple.o test/run_tests-test-pipe-connect-prepare.o test/run_tests-test-pipe-getsockname.o test/run_tests-test-pipe-pending-instances.o test/run_tests-test-pipe-sendmsg.o test/run_tests-test-pipe-server-close.o test/run_tests-test-pipe-close-stdout-read-stdin.o test/run_tests-test-pipe-set-non-blocking.o test/run_tests-test-pipe-set-fchmod.o test/run_tests-test-platform-output.o test/run_tests-test-poll.o test/run_tests-test-poll-close.o test/run_tests-test-poll-close-doesnt-corrupt-stack.o test/run_tests-test-poll-closesocket.o test/run_tests-test-poll-multiple-handles.o test/run_tests-test-poll-oob.o test/run_tests-test-process-priority.o test/run_tests-test-process-title.o test/run_tests-test-process-title-threadsafe.o test/run_tests-test-queue-foreach-delete.o test/run_tests-test-random.o test/run_tests-test-readable-on-eof.o test/run_tests-test-ref.o test/run_tests-test-run-nowait.o test/run_tests-test-run-once.o test/run_tests-test-semaphore.o test/run_tests-test-shutdown-close.o test/run_tests-test-shutdown-eof.o test/run_tests-test-shutdown-simultaneous.o test/run_tests-test-shutdown-twice.o test/run_tests-test-signal-multiple-loops.o test/run_tests-test-signal-pending-on-close.o test/run_tests-test-signal.o test/run_tests-test-socket-buffer-size.o test/run_tests-test-spawn.o test/run_tests-test-stdio-over-pipes.o test/run_tests-test-strscpy.o test/run_tests-test-strtok.o test/run_tests-test-tcp-alloc-cb-fail.o test/run_tests-test-tcp-bind-error.o test/run_tests-test-tcp-bind6-error.o test/run_tests-test-tcp-close-accept.o test/run_tests-test-tcp-close-while-connecting.o test/run_tests-test-tcp-close-after-read-timeout.o test/run_tests-test-tcp-close.o test/run_tests-test-tcp-close-reset.o test/run_tests-test-tcp-create-socket-early.o test/run_tests-test-tcp-connect-error-after-write.o test/run_tests-test-tcp-connect-error.o test/run_tests-test-tcp-connect-timeout.o test/run_tests-test-tcp-connect6-error.o test/run_tests-test-tcp-flags.o test/run_tests-test-tcp-open.o test/run_tests-test-tcp-read-stop.o test/run_tests-test-tcp-read-stop-start.o test/run_tests-test-tcp-rst.o test/run_tests-test-tcp-shutdown-after-write.o test/run_tests-test-tcp-unexpected-read.o test/run_tests-test-tcp-oob.o test/run_tests-test-tcp-write-to-half-open-connection.o test/run_tests-test-tcp-write-after-connect.o test/run_tests-test-tcp-writealot.o test/run_tests-test-tcp-write-fail.o test/run_tests-test-tcp-try-write.o test/run_tests-test-tcp-write-in-a-row.o test/run_tests-test-tcp-try-write-error.o test/run_tests-test-tcp-write-queue-order.o test/run_tests-test-test-macros.o test/run_tests-test-thread-equal.o test/run_tests-test-thread.o test/run_tests-test-thread-affinity.o test/run_tests-test-threadpool-cancel.o test/run_tests-test-threadpool.o test/run_tests-test-timer-again.o test/run_tests-test-timer-from-check.o test/run_tests-test-timer.o test/run_tests-test-tmpdir.o test/run_tests-test-tty-duplicate-key.o test/run_tests-test-tty-escape-sequence-processing.o test/run_tests-test-tty.o test/run_tests-test-udp-alloc-cb-fail.o test/run_tests-test-udp-bind.o test/run_tests-test-udp-connect.o test/run_tests-test-udp-connect6.o test/run_tests-test-udp-create-socket-early.o test/run_tests-test-udp-dgram-too-big.o test/run_tests-test-udp-ipv6.o test/run_tests-test-udp-mmsg.o test/run_tests-test-udp-multicast-interface.o test/run_tests-test-udp-multicast-interface6.o test/run_tests-test-udp-multicast-join.o test/run_tests-test-udp-multicast-join6.o test/run_tests-test-udp-multicast-ttl.o test/run_tests-test-udp-open.o test/run_tests-test-udp-options.o test/run_tests-test-udp-send-and-recv.o test/run_tests-test-udp-send-hang-loop.o test/run_tests-test-udp-send-immediate.o test/run_tests-test-udp-sendmmsg-error.o test/run_tests-test-udp-send-unreachable.o test/run_tests-test-udp-try-send.o test/run_tests-test-udp-recv-in-a-row.o test/run_tests-test-uname.o test/run_tests-test-walk-handles.o test/run_tests-test-watcher-cross-stop.o test/run_tests-runner-unix.o  -lutil -L/opt/local/lib ./.libs/libuv.dylib -lMacportsLegacySupport -pthread
/usr/bin/make  check-TESTS
The libuv test suite cannot be run as root.
FAIL: test/run-tests
======================================================
1 of 1 test failed
Please report to [https://github.com/libuv/libuv/issues](https://github.com/libuv/libuv/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc)
======================================================
make[1]: *** [check-TESTS] Error 1
make: *** [check-am] Error 2
Command failed:  cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_devel_libuv-devel/libuv-devel/work/libuv-1.46.0" && /usr/bin/make check 
Exit code: 2

because there is no premade installer for 10.6-PPC for you to run, the macports user and group were never created on that system. Therefore macports is running as root all the time.

The instructions that would have been run, if an installer existed, are here:

https://github.com/macports/macports-base/blob/3dac040b71d170670fd26bfd60a024dd03542a26/portmgr/dmg/postflight.in#L171

and will give you some idea of what needs to be done to create the macports user.

@pmetzger
Copy link
Member

Howdy! How do we get this finished off?

@herbygillot
Copy link
Member Author

We updated libuv-devel recently. As of now, it's failing to build on macOS 10.14 and 10.15:

https://trac.macports.org/ticket/69248

If we get that figured out, then we could move forward on getting this main libuv port upgraded to what we have in libuv-devel.

@herbygillot
Copy link
Member Author

@herbygillot We should make all dependents of libuv use path-style syntax by the way.

Agreed, need to do so in another commit/PR.

@pmetzger
Copy link
Member

@herbygillot What should we do with this PR?

@pmetzger
Copy link
Member

pmetzger commented Mar 7, 2024

@herbygillot Can this be closed given the newer request?

@pmetzger
Copy link
Member

@herbygillot ?

@reneeotten
Copy link
Contributor

Feel free to reopen if/when there is any progress on this PR

@reneeotten reneeotten closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: update
6 participants