Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgpg-error: additionally build static libs #20428

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

herbygillot
Copy link
Member

@herbygillot herbygillot commented Sep 14, 2023

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install sudo port -d destroot?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@Schamschula for port libgpg-error.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Sep 14, 2023
@Schamschula
Copy link
Contributor

What dependency needs to be built statically?

@herbygillot
Copy link
Member Author

What dependency needs to be built statically?

Perhaps the question for @barracuda156, who opened the original Trac issue ( https://trac.macports.org/ticket/67950 ).

@Schamschula
Copy link
Contributor

Yes, as I mention in the trac ticket, I would prefer not to be adding static libraries unless there is a good reason for it.

Static libraries have not been a thing on the Mac platform since 10.3 or so.

@Schamschula Schamschula merged commit 9352521 into macports:master Sep 24, 2023
3 checks passed
@barracuda156
Copy link
Contributor

@Schamschula Thank you for merging!

P. S. Re trac ticket: that arose in a process of fixing retroshare build, as I remember. It is not yet in Macports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
4 participants