Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdf5: Fix build with Xcode/CLT 15.0 #20572

Closed
wants to merge 2 commits into from

Conversation

Dave-Allured
Copy link
Contributor

Description

  • Remove -commons from configure, not supported in Xcode/CLT 15.0.
  • -commons is no longer needed for HDF5 series 10.0 and later.

Closes: https://trac.macports.org/ticket/68194
Upstream PR: HDFGroup/hdf5#3581
Resolves issues in preliminary PR: #20553

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

CI only
macOS 11, 12, 13, x86_64 only

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

* Remove -commons from configure, not supported in Xcode/CLT 15.0.
* -commons no longer needed for HDF5 series 10.0 and later.

Closes: https://trac.macports.org/ticket/68194
Upstream PR: HDFGroup/hdf5#3581
@macportsbot
Copy link

Notifying maintainers:
@eborisch for port hdf5.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Sep 24, 2023
@reneeotten
Copy link
Contributor

another fix was committed in 3d830f3 ; assuming that that fixes the same underlying issue/symptom, this PR is perhaps not needed anymore. But admittedly, I haven't followed this so I cannot really tell if that is the case.
@Schamschula

@Dave-Allured
Copy link
Contributor Author

@reneeotten, yes, that should fix current HDF5 builds with Xcode/CLT 15.0. That is different than the new upstream fix, which looks to be compatible with the new Xcode linker. So, two different ways to fix the same build problem. However, the new commit suggests wider problems with the new linker. So go with that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
4 participants