Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qgis3{-ltr}: change linking from MacPorts' to the System's libunwind #20608

Closed
wants to merge 1 commit into from

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Sep 27, 2023

Description

QGIS does not use libunwind, but due to it's dependence to PDAL (which does use libunwind) and the following presence of libunwind in $prefix/lib, causes the MacPorts version to be picked up by the linker instead of the system's version. A thrown exception is therefore wrongfully handled by both versions, causing crash.

This is a workaround, awaiting separate prefix for the port libunwind. See https://trac.macports.org/ticket/66250#comment:1

Closes https://trac.macports.org/ticket/68250

Putting up this initially as a draft, it works for me, but this workaround probably needs to be run conditionally depending on OS version.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 13.6 22G120 arm64
Xcode 15.0 15A240d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

QGIS does not use libunwind, but due to it's dependence to PDAL (which does use libunwind)
and the following presence of libunwind in $prefix/lib, causes the MacPorts version to be picked
up by the linker instead of the system's version. A thrown exception is therefore wrongfully handled
by both versions, causing crash.

This is a workaround, awaiting separate prefix for the port libunwind.
See https://trac.macports.org/ticket/66250#comment:1

Closes https://trac.macports.org/ticket/68250
@macportsbot
Copy link

Notifying maintainers:
@Veence for port qgis3.

@nilason
Copy link
Contributor Author

nilason commented Sep 29, 2023

Closing in favour of #20638, #20632 or whatever we come to agree on.

@nilason nilason closed this Sep 29, 2023
@nilason nilason deleted the qgis3_fix-libunwind branch October 5, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants