clang-14: Fix build under Xcode 15, re-enabling sanitizers on macOS 14 #20625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also reverts the following as they relate to clang-14: 370d81a llvm-14: Allow build on darwin23 but disable sanitizers 0c2af47 llvm-{10-14}: Restrict to darwin < 23 Note that the actual incompatibility was not strictly between clang-14 and Darwin 23 (macOS 14) as these previous commits suggest. The incompatibility existed between clang-14 and the macOS 14 SDK, which is part of Xcode 15. The incompatibility equally affected clang-14 on macOS 13 (Darwin 22) using Xcode 15. This also makes the compiler-rt build for various runtimes targeting iOS and iOS Simulator work correctly by removing the macOS SDK -syslibroot when linking, allowing the platform-specific SDK provided by the Clang build to be effective. Fixes: https://trac.macports.org/ticket/68257
| foreach rtl_dir {asan lsan stats tsan/rtl ubsan ubsan_minimal} { | ||
| set rtl [lindex [split ${rtl_dir} /] 0] | ||
| foreach rtl_os {ios iossim} { | ||
| reinplace "s|-Wl,-syslibroot,${configure.sdkroot}||" "${workpath}/build/projects/compiler-rt/lib/${rtl_dir}/CMakeFiles/clang_rt.${rtl}_${rtl_os}_dynamic.dir/link.txt" |
There was a problem hiding this comment.
Is this something that we should also do for clang-15 and newer ?
There was a problem hiding this comment.
The ports for clang-15 and newer don’t build runtime libraries for ios and iossim at the moment, because
# Disable iOS support
# To Be reviewed with later versions
# https://reviews.llvm.org/D133273
configure.args-append -DCOMPILER_RT_ENABLE_IOS=OFF
I’m not sure exactly why this was disabled—if it was for this reason, then yes, sure. But I don’t know whether there’s another reason standing in the way. That’s why I only did it for clang-14.
There was a problem hiding this comment.
Ah yes, good point. It would be good to review that at some point but its not required for this PR. Thanks for your contribution...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also reverts the following as they relate to clang-14:
370d81a llvm-14: Allow build on darwin23 but disable sanitizers
0c2af47 llvm-{10-14}: Restrict to darwin < 23
Note that the actual incompatibility was not strictly between clang-14 and Darwin 23 (macOS 14) as these previous commits suggest. The incompatibility existed between clang-14 and the macOS 14 SDK, which is part of Xcode 15. The incompatibility equally affected clang-14 on macOS 13 (Darwin 22) using Xcode 15.
This also makes the compiler-rt build for various runtimes targeting iOS and iOS Simulator work correctly by removing the macOS SDK -syslibroot when linking, allowing the platform-specific SDK provided by the Clang build to be effective.
Fixes: https://trac.macports.org/ticket/68257
Description
Type(s)
Tested on
macOS 14.0 23A344 arm64
Xcode 15.0 15A240d
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?@cjones051073