Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vorbis-tools: Add missing dependency #20700

Merged
merged 1 commit into from Oct 4, 2023
Merged

vorbis-tools: Add missing dependency #20700

merged 1 commit into from Oct 4, 2023

Conversation

RobK88
Copy link
Contributor

@RobK88 RobK88 commented Oct 4, 2023 •
edited

Description

  • Add missing dependency port:opusfile
  • Change depends_lib to depends_lib-append
  • Bump revision number

CLOSES: https://trac.macports.org/ticket/68313

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.13.6 17G14042 x86_64
Xcode 10.1 10B61

Verification

Have you

  • [x ] followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@RobK88 RobK88 changed the title vorbis-tools: fix +universal build vorbis-tools: Add missing dependency Oct 4, 2023
@RobK88
Copy link
Contributor Author

RobK88 commented Oct 4, 2023 •
edited

I probably should have also changed depends_lib to depends_lib-append to comply with current practice.

@herbygillot
Copy link
Member

I probably should have also changed depends_lib to depends_lib-append to comply with current practice.

Agreed. If you could make that change and amend this existing commit, that would be good.

@RobK88
vorbis-tools: add missing dependency
50ff519 
* Add missing dependency port:opusfile
* Change depends_lib to depends_lib-append
* Bump revision number

CLOSES:  https://trac.macports.org/ticket/68313
@RobK88
Copy link
Contributor Author

RobK88 commented Oct 4, 2023

@herbygillot -- Done. If you see anything else that should be changed in the Portfile, please let me know.

@herbygillot herbygillot merged commit 51969ad into macports:master Oct 4, 2023
3 checks passed
@herbygillot
Copy link
Member

Thank you @RobK88; merged.

@RobK88 RobK88 deleted the vorbis-tools branch October 4, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintainer: none type: bugfix
Milestone
No milestone
3 participants
@RobK88 @herbygillot @macportsbot