Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java 1.0 portgroup: remove java.enforce option #20865

Merged
merged 1 commit into from Oct 21, 2023

Conversation

chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented Oct 13, 2023

Closes: https://trac.macports.org/ticket/68449

Description

Reasons for removal:

  • It would be better for ports to never hardcode JDK paths in build outputs.
  • java.enforce does not actually force a port to build using java.fallback, because it does not force JAVA_HOME to point to java.fallback rather than some other Java installation.
  • This option is no longer used by any ports (it was only briefly used by abcl).
Verification

Have you

@chrstphrchvz chrstphrchvz changed the title java 1.0 portgroup: remove java.enforce option java 1.0 portgroup: remove java.enforce option Oct 13, 2023
@mascguy
Copy link
Member

mascguy commented Oct 13, 2023

When changing things done by others, we should be sure to tag them for review/comment.

Specifically, Kirill should have an opportunity to elaborate on the change, and/or veto it.

CC: @catap

@mascguy mascguy self-assigned this Oct 13, 2023
@chrstphrchvz
Copy link
Contributor Author

I could have been more conscientious about this by just mentioning it on the original PR.

I would also like to ask @breun for any feedback on this.

@breun
Copy link
Member

breun commented Oct 13, 2023

@chrstphrchvz Fine with me. (I didn’t know of this flag and I’ve never used it.)

@mascguy
Copy link
Member

mascguy commented Oct 21, 2023

@catap Kirill, thoughts on this?

@catap
Copy link
Contributor

catap commented Oct 21, 2023

Sorry. Missed that. Feel free to remove it

@mascguy
Copy link
Member

mascguy commented Oct 21, 2023

Sorry. Missed that. Feel free to remove it

Sounds good, thanks for confirming Kirill!

@mascguy mascguy merged commit 9236110 into macports:master Oct 21, 2023
3 checks passed
@chrstphrchvz chrstphrchvz deleted the rm-enforce branch October 21, 2023 15:16
@catap
Copy link
Contributor

catap commented Nov 29, 2023

Seems that the issue which I've tried to fix via this option still here: https://trac.macports.org/ticket/68804

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants