-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moar, MoarVM: declare mutual conflict #20930
Conversation
Notifying maintainers: |
Seems ok to me. |
I just updated the PR message to include a link to a ticket opened (https://trac.macports.org/ticket/68491). The commit references the ticket, but the longer-term goal would be to allow these to be installed side-by-side by renaming the binary for |
Definitely, a proper solution would be to allow these to co-exist. |
Please add the explicit line:
...to the commit message so that the Trac issue automatically gets a reference to this on commit. |
Thanks. I wasn't quite sure how to make that reference and couldn't find it after a couple of minutes of searching. I’ll have that up in a couple of minutes… and done. |
Both `moar` and `MoarVM` want to install binaries called `moar`. Currently, this is not resolved until the install phase of the later installed port. See: https://trac.macports.org/ticket/68491
4a38592
to
b5bc62b
Compare
Thanks for catching this. |
I didn’t catch it, Kenneth Wolcott did. I just opened the ticket and made the first step toward potentially resolving this. There is an ongoing discussion with the maintainer in walles/moar#143, but action on https://trac.macports.org/ticket/68491 may require updates to other ports containing his work to recognize |
This implements the alternative route described in trac:68491 to enable a compatibility workaround to use both textproc/moar and lang/MoarVM since they both wish to install `moar` binaries. Previously, macports#20930 marked moar and MoarVM as mutually conflicting. This conflict state remains, but a new `+pager` variant is added which installs `textproc/moar` as `moar-pager`. The manpage is also installed as `moar-pager.1` and the contents are patched to reflect the updated name. This variant *removes* the `MoarVM` conflict marker. Closes: https://trac.macports.org/ticket/68491
This implements the alternative route described in trac:68491 to enable a compatibility workaround to use both textproc/moar and lang/MoarVM since they both wish to install `moar` binaries. Previously, #20930 marked moar and MoarVM as mutually conflicting. This conflict state remains, but a new `+pager` variant is added which installs `textproc/moar` as `moar-pager`. The manpage is also installed as `moar-pager.1` and the contents are patched to reflect the updated name. This variant *removes* the `MoarVM` conflict marker. Closes: https://trac.macports.org/ticket/68491
Description
This is the first step of a possible multiple-step realignment so that people who wish to do so might be able to use both
moar
and MoarVM (required for NQP and Rakudo).This step is required even if no other steps are taken, as trying to install either of these ports after the other without this results in a delayed error rather than an upfront prevention.
Addresses the first step in https://trac.macports.org/ticket/68491, but does not complete it.
Type(s)
Tested on
macOS 13.6 22G120 arm64
Xcode 15.0 15A240d
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?I have not tried to run existing tests or installs because the only thing added was
conflicts
and I currently use neither port. However, I did checkport info
for each port and they properly indicate mutual conflict.