Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moar, MoarVM: declare mutual conflict #20930

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

halostatue
Copy link
Contributor

@halostatue halostatue commented Oct 17, 2023

Description

This is the first step of a possible multiple-step realignment so that people who wish to do so might be able to use both moar and MoarVM (required for NQP and Rakudo).

This step is required even if no other steps are taken, as trying to install either of these ports after the other without this results in a delayed error rather than an upfront prevention.

Addresses the first step in https://trac.macports.org/ticket/68491, but does not complete it.

Type(s)
  • enhancement
Tested on

macOS 13.6 22G120 arm64
Xcode 15.0 15A240d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

I have not tried to run existing tests or installs because the only thing added was conflicts and I currently use neither port. However, I did check port info for each port and they properly indicate mutual conflict.

@macportsbot
Copy link

Notifying maintainers:
@barracuda156 for port MoarVM.
@herbygillot for port moar.
@jlopezr for port moar.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port labels Oct 17, 2023
@jlopezr
Copy link
Contributor

jlopezr commented Oct 17, 2023

Seems ok to me.

@halostatue
Copy link
Contributor Author

I just updated the PR message to include a link to a ticket opened (https://trac.macports.org/ticket/68491). The commit references the ticket, but the longer-term goal would be to allow these to be installed side-by-side by renaming the binary for textproc/moar and/or the port itself.

@barracuda156
Copy link
Contributor

Definitely, a proper solution would be to allow these to co-exist.

@herbygillot
Copy link
Member

I just updated the PR message to include a link to a ticket opened (https://trac.macports.org/ticket/68491). The commit references the ticket, but the longer-term goal would be to allow these to be installed side-by-side by renaming the binary for textproc/moar and/or the port itself.

Please add the explicit line:

See: https://trac.macports.org/ticket/68491

...to the commit message so that the Trac issue automatically gets a reference to this on commit.

@halostatue
Copy link
Contributor Author

halostatue commented Oct 17, 2023

Thanks. I wasn't quite sure how to make that reference and couldn't find it after a couple of minutes of searching. I’ll have that up in a couple of minutes…

and done.

Both `moar` and `MoarVM` want to install binaries called `moar`.
Currently, this is not resolved until the install phase of the later
installed port.

See: https://trac.macports.org/ticket/68491
@herbygillot herbygillot merged commit e341066 into macports:master Oct 17, 2023
3 checks passed
@herbygillot
Copy link
Member

Thanks for catching this.

@halostatue halostatue deleted the moar-binary-conflicts branch October 18, 2023 02:05
@halostatue
Copy link
Contributor Author

I didn’t catch it, Kenneth Wolcott did. I just opened the ticket and made the first step toward potentially resolving this.

There is an ongoing discussion with the maintainer in walles/moar#143, but action on https://trac.macports.org/ticket/68491 may require updates to other ports containing his work to recognize moar-pager as a valid name (although we would need to look for moar-pager before moar because MoarVM might be installed).

halostatue added a commit to halostatue/macports-ports that referenced this pull request Dec 5, 2023
This implements the alternative route described in trac:68491 to enable
a compatibility workaround to use both textproc/moar and lang/MoarVM
since they both wish to install `moar` binaries.

Previously, macports#20930 marked moar and MoarVM as mutually conflicting. This
conflict state remains, but a new `+pager` variant is added which
installs `textproc/moar` as `moar-pager`. The manpage is also installed
as `moar-pager.1` and the contents are patched to reflect the updated
name.

This variant *removes* the `MoarVM` conflict marker.

Closes: https://trac.macports.org/ticket/68491
herbygillot pushed a commit that referenced this pull request Dec 5, 2023
This implements the alternative route described in trac:68491 to enable
a compatibility workaround to use both textproc/moar and lang/MoarVM
since they both wish to install `moar` binaries.

Previously, #20930 marked moar and MoarVM as mutually conflicting. This
conflict state remains, but a new `+pager` variant is added which
installs `textproc/moar` as `moar-pager`. The manpage is also installed
as `moar-pager.1` and the contents are patched to reflect the updated
name.

This variant *removes* the `MoarVM` conflict marker.

Closes: https://trac.macports.org/ticket/68491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: enhancement
5 participants