Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-poppler-qt5: fix build, add Python 3.11 #20980

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

chrstphrchvz
Copy link
Contributor

Fixes: https://trac.macports.org/ticket/68287

Description

Type(s)
  • bugfix
  • enhancement
Tested on

macOS 12.7
Xcode 14.2
Python 3.10.13, 3.11.6
configure.sdk_version=13.1

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@dliessi for port py-poppler-qt5.

@chrstphrchvz
Copy link
Contributor Author

The CI failed because of e.g. Project ERROR: Could not resolve SDK Path for 'macosx12.3' using --show-sdk-path, which had been reported in https://trac.macports.org/ticket/65600 and encountered by various other qt5 ports. It is unrelated to the issue addressed by this PR.

@pmetzger pmetzger merged commit 66f1067 into macports:master Oct 23, 2023
0 of 3 checks passed
@chrstphrchvz chrstphrchvz deleted the trac68287 branch October 23, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants