shards: new port, version 0.8.1-devel #2101

conradwt · 2018-06-26T19:30:34Z

Description

Shards is a dependency manager for the Crystal Programming Language.

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 10.14 18A314h
Xcode 10.0 10L177m

Verification

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL?
checked your Portfile with port lint?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?

mf2k · 2018-06-26T19:39:20Z

www/shards/Portfile

+depends_lib         port:crystal
+
+checksums           rmd160  dc60ef24d2e9e812138e042659c6f1599c68a312 \
+                    sha256  d4a56101262ae9a9ce4352f534d532941dc2a2429e67fc263460d682eba088ff


Add the size parameter at the end.

Yes, I can add the size. How is the size specified and can you explain the reasoning for it?

It's a new parameter that is not well documented yet. But it is being added to all ports as we move forward. Knowing the file size acts as a sanity check and also allows port to provide feedback while downloading such as telling the user how much data is left to download.

mf2k · 2018-06-26T19:40:36Z

www/shards/Portfile

+PortGroup           github 1.0
+
+name                shards
+version             0.8.1-devel


Remove these two lines because the GitHub portgroup already sets them to these values.

Will do and thanks for the clarification.

mf2k · 2018-06-26T19:40:53Z

www/shards/Portfile

+
+github.setup        crystal-lang shards 0.8.1-devel v
+
+epoch               1


Remove the epoch because it is only added if needed.

Will do and thanks for the clarification.

mf2k · 2018-06-26T19:41:14Z

www/shards/Portfile

+long_description    Shards is a dependency manager for the Crystal Programming Language.
+
+homepage            https://github.com/crystal-lang/shards
+master_sites        https://github.com/conradwt/shards/archive/v${github.version}


These two lines can also be removed.

mf2k · 2018-06-26T19:41:30Z

www/shards/Portfile

+platforms           darwin
+supported_archs     noarch
+license             Apache-2
+maintainers         {@conradwt gmail.com:conradwt}


Can openmaintainer be added here?

Yes, I can add openmaintainer. Can you explain the reasoning for it?

It is normal practice for ports maintained by non-committers to be openmaintainer so that committers can make minor fixes without waiting for approval. Most often this means we can increase the revision as needed when a dependency gets updated and it affects your port.

mf2k · 2018-06-26T19:41:57Z

I'm not sure why all of my comments didn't show up the first time.

macportsbot · 2018-06-26T19:53:32Z

Travis Build #2773 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

conradwt · 2018-06-27T01:44:15Z

@mf2k I have updated the Portfile with the requested changes and thanks for taking the time to review it.

macportsbot · 2018-06-27T01:57:41Z

Travis Build #2775 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

macportsbot · 2018-06-27T02:14:03Z

Travis Build #2776 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

chrstphrchvz · 2018-06-27T03:49:08Z

@conradwt You might need to check that your new commit was rebased properly. It looks as if any MacPorts' commits from the past day got squashed into your commit, so now your commit is trying to update a bunch of unrelated files.

macportsbot · 2018-06-27T04:02:42Z

Travis Build #2779 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

macportsbot · 2018-06-27T04:28:48Z

Travis Build #2780 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

macportsbot · 2018-06-27T04:51:02Z

Travis Build #2781 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

macportsbot · 2018-06-27T05:27:07Z

Travis Build #2782 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

macportsbot · 2018-06-27T05:50:34Z

Travis Build #2783 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

pmetzger · 2018-06-27T15:21:09Z

Your commit message format isn't per our standards. Try shards: new port, version 0.8.1 or some such.

macportsbot · 2018-06-27T23:46:38Z

Travis Build #2792 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

pmetzger · 2018-06-28T17:41:54Z

www/shards/Portfile

+
+categories          www
+platforms           darwin
+supported_archs     noarch


Is it truly the case that this port installs no architecture specific files at all?

pmetzger · 2018-06-28T17:42:10Z

www/shards/Portfile

+supported_archs     noarch
+license             Apache-2
+maintainers         {@conradwt gmail.com:conradwt} \
+                    openmaintainer


Generally these should be on the same line. It makes grepping easier.

pmetzger · 2018-06-28T17:42:50Z

www/shards/Portfile

+
+destroot.args       PREFIX=${prefix}
+
+test.run            no


Are you disabling tests for a specific reason?

pmetzger · 2018-06-28T17:43:33Z

Made a few more comments. Sorry this is taking so long, @conradwt, we'll try to merge it expeditiously once it's all clean.

conradwt · 2018-06-28T21:50:57Z

@pmetzger I have updated the Portfile based on you most recent comments. Thanks again for the feedback.

macportsbot · 2018-06-28T22:05:43Z

Travis Build #2798 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

macportsbot · 2018-06-28T22:24:07Z

Travis Build #2799 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

macportsbot · 2018-06-29T01:58:57Z

Travis Build #2800 Errored.

Lint results

--->  Verifying Portfile for shards
--->  0 errors and 0 warnings found.

pmetzger · 2018-06-30T17:55:52Z

Merged! Sorry for all the delays, @conradwt!

pmetzger · 2018-06-30T17:57:10Z

www/shards/Portfile

+
+github.setup        crystal-lang shards 0.8.1-devel v
+
+categories          www


By the way, I only just realized, is this actually www specific? If not, maybe it belongs in another category?

This port is applicable to Crystal Programming Language and its web development framework called Amber. Next, this port would be in similar categories as the rb-bundler port. Thus, it would it maybe should be something like crystal, www, devel. Would this be better?

Probably, yes, though we don't yet have a crystal category. That said, if we get enough crystal code, one would be appropriate. Certainly devel would be a good addition. You should feel free to request that in a PR.

mohd-akram · 2018-07-02T10:36:08Z

This seems like it should belong solely in devel as it is a package manager like devel/npm6. As far as I can tell, Amber is a web framework package that can be installed by shards, but it is not directly related to it.

pmetzger · 2018-07-02T13:54:04Z

Yah, it does make some sense for it to just be devel. @conradwt, please submit a pull request. If we later get enough crystal packages we can also have a crystal directory and category.

conradwt · 2018-07-02T20:06:49Z

@pmetzger Where would one find the instructions for crafting a PR for moving a port from one category to another?

pmetzger · 2018-07-03T15:44:03Z

There's nothing to it. Just do a "git mv" on a branch, and also change the category line. It's that easy.

macportsbot added the type: submission label Jun 26, 2018

mf2k requested changes Jun 26, 2018

View reviewed changes

mf2k reviewed Jun 26, 2018

View reviewed changes

conradwt force-pushed the new-port-shards branch from 3d3dc0d to d31a165 Compare June 27, 2018 01:42

conradwt force-pushed the new-port-shards branch from 62f8391 to 3441736 Compare June 27, 2018 03:31

conradwt changed the title ~~New Port: SHards~~ [WIP] New Port: SHards Jun 27, 2018

conradwt force-pushed the new-port-shards branch from 0797d02 to ecfdcc4 Compare June 27, 2018 05:03

conradwt force-pushed the new-port-shards branch from ecfdcc4 to 3d049cd Compare June 27, 2018 05:27

conradwt force-pushed the new-port-shards branch from 3d049cd to 3470ddb Compare June 27, 2018 22:51

conradwt changed the title ~~[WIP] New Port: SHards~~ shards: new port, version 0.8.1-devel Jun 27, 2018

pmetzger requested changes Jun 28, 2018

View reviewed changes

conradwt force-pushed the new-port-shards branch 2 times, most recently from 875d840 to b7420f9 Compare June 28, 2018 21:48

shards: new port, version 0.8.1-devel

664c813

conradwt force-pushed the new-port-shards branch from b7420f9 to 664c813 Compare June 29, 2018 00:48

mf2k approved these changes Jun 29, 2018

View reviewed changes

pmetzger merged commit b242c46 into macports:master Jun 30, 2018

pmetzger reviewed Jun 30, 2018

View reviewed changes


		github.setup crystal-lang shards 0.8.1-devel v

		categories www


		destroot.args PREFIX=${prefix}

		test.run no

shards: new port, version 0.8.1-devel #2101

shards: new port, version 0.8.1-devel #2101

Conversation

conradwt commented Jun 26, 2018

Description

Type(s)

Tested on

Verification

Choose a reason for hiding this comment

conradwt Jun 27, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mf2k Jun 27, 2018 • edited

Choose a reason for hiding this comment

mf2k commented Jun 26, 2018

macportsbot commented Jun 26, 2018

conradwt commented Jun 27, 2018 • edited

macportsbot commented Jun 27, 2018

macportsbot commented Jun 27, 2018

chrstphrchvz commented Jun 27, 2018

macportsbot commented Jun 27, 2018

macportsbot commented Jun 27, 2018

macportsbot commented Jun 27, 2018

macportsbot commented Jun 27, 2018

macportsbot commented Jun 27, 2018

pmetzger commented Jun 27, 2018

macportsbot commented Jun 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pmetzger commented Jun 28, 2018

conradwt commented Jun 28, 2018

macportsbot commented Jun 28, 2018

macportsbot commented Jun 28, 2018

macportsbot commented Jun 29, 2018

pmetzger commented Jun 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mohd-akram commented Jul 2, 2018

pmetzger commented Jul 2, 2018

conradwt commented Jul 2, 2018 • edited

pmetzger commented Jul 3, 2018

conradwt Jun 27, 2018 •

edited

mf2k Jun 27, 2018 •

edited

conradwt commented Jun 27, 2018 •

edited

conradwt commented Jul 2, 2018 •

edited