Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml-astring: fix extract phase #21102

Closed
wants to merge 1 commit into from

Conversation

pguyot
Copy link
Contributor

@pguyot pguyot commented Oct 27, 2023

Fix build by ensuring bzip2 is used. It worked on macOS 11+ because gzip on these platforms can also process bzip2 archives.

Closes: https://trac.macports.org/ticket/68562

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.0 23A344 x86_64
Xcode 15.0.1 15A507

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Fix build by ensuring bzip2 is used. It worked on macOS 11+ because gzip
on these platforms can also process bzip2 archives.

Closes: https://trac.macports.org/ticket/68562

Signed-off-by: Paul Guyot <pguyot@kallisys.net>
@pguyot pguyot force-pushed the w43/ocaml-astring-fix-build branch from f060b16 to 6648977 Compare October 27, 2023 04:15
@barracuda156
Copy link
Contributor

CI failed due to: #21098 (comment)
Just wait until that is fixed, I guess.

@reneeotten
Copy link
Contributor

@ryandesign committed this change already, so closing the PR.

@reneeotten reneeotten closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants