py-sip4: fix installation with python3* #21240
Conversation
|
Notifying maintainers: |
python/py-sip4/Portfile
Outdated
| @@ -66,7 +66,7 @@ if {${name} ne ${subport}} { | |||
| checksums rmd160 9709eda79d7e0a73eca82e25cbbfd0af6da074c8 \ | |||
| sha256 b39d93e937647807bac23579edbff25fe46d16213f708370072574ab1f1b4211 \ | |||
| size 1056384 | |||
| revision 1 | |||
| revision 2 | |||
There was a problem hiding this comment.
Revision should not be increased unless you've changed something that would be relevant for those users who were already able to install the port. It's explained in the MacPorts Guide.
There was a problem hiding this comment.
How do we know that no one installed it since it was broken? Notice, it did install, but installation was wrong.
P. S. I am not gonna insist here, but IMO it should be rebased, since it may affect users who already installed the port.
There was a problem hiding this comment.
Notice, it did install, but installation was wrong.
You're absolutely right, the revision needs to be increased.
There was a problem hiding this comment.
I am not gonna insist here
Please do insist. I'm not infallible and in this case I did a poor drive-by review without understanding that the problem was not fixing a build failure. Fixing a build failure = don't increase revision; fixing wrong installed files = do increase revision.
|
@ryandesign @reneeotten @jmroot Could we merge this now? |
Fixes: https://trac.macports.org/ticket/68643
Description
Unbreak py3*-sip4 installation.
@ryandesign Now I can build
py310-pyqt4with no issues.Type(s)
Tested on
macOS 10.6
Xcode 3.2
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?