Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvterm,neovim*: update to latest #21255

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

casr
Copy link
Contributor

@casr casr commented Nov 6, 2023

Description

  • update libvterm to 0.3.3
  • update neovim to v0.9.4
  • update neovim-devel to 20231106

Note: a recent update to neovim-devel set the minimum version of libvterm to 0.3.3

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.6.7 21G651 arm64
Xcode 14.2 14C18

Verification

Have you

@macportsbot
Copy link

Notifying maintainers:
@l2dy for port neovim-devel, neovim.
@raimue for port libvterm, neovim.
@judaew for port neovim-devel, neovim.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port labels Nov 6, 2023
@casr casr force-pushed the libvterm_neovim branch 2 times, most recently from 71fd7a8 to cbb5f60 Compare November 6, 2023 23:09
devel/libvterm/Portfile Outdated Show resolved Hide resolved
devel/libvterm/Portfile Outdated Show resolved Hide resolved
@raimue
Copy link
Member

raimue commented Nov 6, 2023

Thanks for the port update! Looks good to me, I just suggested a few minor whitespace fixes. Once these are fixed, if other reviewers get to this before me, this PR can be merged.

@casr
Copy link
Contributor Author

casr commented Nov 7, 2023

I've fixed those points you raised. Thanks for the review @raimue

@raimue raimue merged commit 9db2260 into macports:master Nov 7, 2023
3 checks passed
@raimue
Copy link
Member

raimue commented Nov 7, 2023

Thanks again for the port update! 👍

@casr casr deleted the libvterm_neovim branch November 7, 2023 22:18
@casr
Copy link
Contributor Author

casr commented Nov 7, 2023

Thanks for merging it!

@vkocubinsky
Copy link

Hi, thanks for update neovim port. I recently switch to macports from brew, tried to install neovim to mac M1, and get an error

sudo port -t install neovim
--->  Computing dependencies for neovim
--->  Fetching archive for neovim
--->  Attempting to fetch neovim-0.9.4_0.darwin_23.arm64.tbz2 from https://fra.de.packages.macports.org/neovim
--->  Attempting to fetch neovim-0.9.4_0.darwin_23.arm64.tbz2 from https://nue.de.packages.macports.org/neovim
--->  Attempting to fetch neovim-0.9.4_0.darwin_23.arm64.tbz2 from https://cph.dk.packages.macports.org/neovim
--->  Building neovim
Error: Failed to build neovim: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_editors_neovim/neovim/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
Error: Processing of port neovim failed

Indeed there is no file neovim-0.9.4_0.darwin_23.arm64.tbz2 (but exists file with very close name neovim-0.9.4_0.darwin_22.arm64.tbz2)

 curl https://fra.de.packages.macports.org/neovim/|grep arm64|grep 0.9.4
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 23401    0 23401    0     0   123k      0 --:--:-- --:--:-- --:--:--  124k
<tr><td valign="top"><img src="/icons/unknown.png" alt="[   ]"></td><td><a href="neovim-0.9.4_0.darwin_20.arm64.tbz2">neovim-0.9.4_0.darwi..&gt;</a></td><td align="right">2023-11-08 02:24  </td><td align="right">6.8M</td><td>&nbsp;</td></tr>
<tr><td valign="top"><img src="/icons/unknown.png" alt="[   ]"></td><td><a href="neovim-0.9.4_0.darwin_20.arm64.tbz2.rmd160">neovim-0.9.4_0.darwi..&gt;</a></td><td align="right">2023-11-08 02:24  </td><td align="right">512 </td><td>&nbsp;</td></tr>
<tr><td valign="top"><img src="/icons/unknown.png" alt="[   ]"></td><td><a href="neovim-0.9.4_0.darwin_21.arm64.tbz2">neovim-0.9.4_0.darwi..&gt;</a></td><td align="right">2023-11-08 00:15  </td><td align="right">6.8M</td><td>&nbsp;</td></tr>
<tr><td valign="top"><img src="/icons/unknown.png" alt="[   ]"></td><td><a href="neovim-0.9.4_0.darwin_21.arm64.tbz2.rmd160">neovim-0.9.4_0.darwi..&gt;</a></td><td align="right">2023-11-08 00:15  </td><td align="right">512 </td><td>&nbsp;</td></tr>
<tr><td valign="top"><img src="/icons/unknown.png" alt="[   ]"></td><td><a href="neovim-0.9.4_0.darwin_22.arm64.tbz2">neovim-0.9.4_0.darwi..&gt;</a></td><td align="right">2023-11-07 23:13  </td><td align="right">6.8M</td><td>&nbsp;</td></tr>
<tr><td valign="top"><img src="/icons/unknown.png" alt="[   ]"></td><td><a href="neovim-0.9.4_0.darwin_22.arm64.tbz2.rmd160">neovim-0.9.4_0.darwi..&gt;</a></td><td align="right">2023-11-07 23:13  </td><td align="right">512 </td><td>&nbsp;</td></tr>

@raimue
Copy link
Member

raimue commented Nov 8, 2023

@vkocubinsky These are attempts to download a precompiled binary archive for the port. This was not yet available from our buildbot when you tried to upgrade. What you found is not for your version of macOS (darwin_23 == macOS 14). The fetch failure for binary archives is normal behavior and not an error.

As the next step, port tried to build neovim locally. However, that build failed for some reason that would be in the mentioned main.log file.

@vkocubinsky
Copy link

thanks for clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: update
6 participants