Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgpointcloud: remove icu dependency, fix '--without-cunit' flag #21415

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Nov 16, 2023

Description

Remove icu dependency for pgpointcloud. While pgpointcloud does indeed links to icu, it does so via xml2-config (of port libxml2). icu is not a direct dependency to pgpointcloud.

Closes https://trac.macports.org/ticket/68704

Unrelated fix for honoring --without-cunit flag is addressed upstreams: pgpointcloud/pointcloud#349

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 13.6.2 22G320 arm64
Xcode 15.0.1 15A507

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@ryandesign
Copy link
Contributor

ryandesign commented Nov 16, 2023

What about the other libxml2 dependencies that had been pulled in by xml2-config --libs—libiconv, xz, zlib? Does pointcloud use them directly—does it still link to them after this change? If not, they should be removed too.

…-cunit' flag

Remove dependencies unnecessary linked to as a result of `xml2-config --libs`.

Closes https://trac.macports.org/ticket/68704

Fix for honoring --without-cunit flag is addressed upstreams:
pgpointcloud/pointcloud#349
@nilason
Copy link
Contributor Author

nilason commented Nov 16, 2023

What about the other libxml2 dependencies that had been pulled in by xml2-config --libs—libiconv, xz, zlib? Does pointcloud use them directly—does it still link to them after this change? If not, they should be removed too.

Good point! lzma and libiconv are not needed now either. Fixed.

@pmetzger pmetzger merged commit a0ba2fb into macports:master Nov 17, 2023
3 checks passed
@nilason nilason deleted the pgpointcloud_rm_icu_dep branch November 18, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants