Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenBLAS: keep cmake integration #21419

Merged
merged 1 commit into from
Nov 17, 2023
Merged

OpenBLAS: keep cmake integration #21419

merged 1 commit into from
Nov 17, 2023

Conversation

catap
Copy link
Contributor

@catap catap commented Nov 16, 2023 •
edited

Description

Type(s)
  • bugfix
Tested on

macOS 12.7.1 21G920 x86_64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@michaelld for port OpenBLAS.
@NicosPavlov for port OpenBLAS.

@catap
Copy link
Contributor Author

catap commented Nov 16, 2023

FYI: @szhorvat

@catap catap force-pushed the OpenBLAS branch 2 times, most recently from 6105583 to 8080682 Compare November 17, 2023 07:01
@catap catap changed the title OpenBLAS: keep camke integration when required OpenBLAS: keep camke integration Nov 17, 2023
@jmroot
Copy link
Member

jmroot commented Nov 17, 2023

Typo in the commit message: cmake->camke

@catap
Copy link
Contributor Author

catap commented Nov 17, 2023

@jmroot thanks for catching that up.

@jmroot jmroot changed the title OpenBLAS: keep camke integration OpenBLAS: keep cmake integration Nov 17, 2023
@szhorvat
Copy link
Contributor

#21423 is dependent on this.

@szhorvat
Copy link
Contributor

Still can't test this on my system because the build process also tries to run the tests, and the tests fail (one crash, then hangs).

@pmetzger pmetzger merged commit ff29da7 into macports:master Nov 17, 2023
3 checks passed
@pmetzger pmetzger mentioned this pull request Nov 17, 2023
Merged
12 tasks
@catap catap deleted the OpenBLAS branch November 17, 2023 18:04
@catap
Copy link
Contributor Author

catap commented Nov 17, 2023

Thanks, Perry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelld michaelld

@NicosPavlov NicosPavlov

Labels
maintainer: open Affects an openmaintainer port maintainer type: bugfix
Milestone
No milestone
7 participants
@catap @macportsbot @jmroot @szhorvat @michaelld @pmetzger @NicosPavlov