devel/boost: add python37 variant, small patch update for python37 #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying maintainers: |
macportsbot
added
by: member
|
Travis Build #2857 Passed. Lint results |
yan12125
reviewed
Jul 6, 2018
| void* convert_to_cstring(PyObject* obj) | ||
| { | ||
| - return PyUnicode_Check(obj) ? _PyUnicode_AsString(obj) : 0; | ||
| + return (void*)(PyUnicode_Check(obj) ? _PyUnicode_AsString(obj) : 0); |
There was a problem hiding this comment.
IMO it's better to pick the upstream commit boostorg/python@660487c. Note that this commit is included in boost 1.67 (https://trac.macports.org/ticket/56294).
There was a problem hiding this comment.
👍 That is indeed much better. This pull request can be closed.
|
Closed at submitter's request. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type(s)
Tested on
macOS 10.13.5 17F77
Xcode 9.4.1 9F2000
Verification
Have you
port lint?sudo port -vst install?