Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avidemux: disable AddressSanitizer #21541

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

chrstphrchvz
Copy link
Contributor

Fixes: https://trac.macports.org/ticket/68336

Description

ASan (AddressSanitizer) is mainly intended for use by developers, and ports should not use it by default because it requires linking to compiler-rt libraries from a specific version of Xcode, command line tools, or MacPorts LLVM. I am not aware why it was originally enabled in this port.

Type(s)
  • bugfix
Tested on

macOS 12.7.1 Intel
Xcode 14.2

Not tested beyond verifying that configure phase emits Address Sanitizer not activated.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@herbygillot herbygillot merged commit a0c91cf into macports:master Nov 27, 2023
3 checks passed
@chrstphrchvz chrstphrchvz deleted the avidemux-no-asan branch November 27, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants