-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fgsl: update to 1.5.0 #21729
fgsl: update to 1.5.0 #21729
Conversation
. * Update FGSL 1.4.0 --> 1.5.0. * Fix Github download. * Fix livecheck. * Add to description: Version 1.5.x is for use with GSL versions >= 2.6. * Add direct link to upstream github repo. * Add myself as co-maintainer. Fiixes: https://trac.macports.org/ticket/68851
Notifying maintainers: |
Can you squash the homepage commit into your original commit? As per guidelines, MacPorts likes to see one commit for updates to a particular port where possible: |
Done. Transfer to new PR: #21746 |
@Dave-Allured please do not close PRs and open new ones for trivial changes like squashing commits. |
@reneeotten Sorry. I use github.com exclusively for security reasons. Github does not provide squash. New PR is the only way I know to comply with squash requests. Your advice? Can you talk github into adding squash? |
what's wrong / insecure of using |
Git is a direct network link between the word and inside my agency's corporate firewall. We have strong security policies. I have no faith in git security. I do not know what it does on the inside. I have no reason to push that firewall if I can work around using github on browser. |
Git has the concept of local and remote branches. When you make a change, and you do a So then when you do a What we mean when we say that you can squash commits is that you can use the Then you would do whats called a force push ( In this way, you can squash the commits on the branch of your pull request without having to close the pull request and open a brand new one using a brand new branch. |
Description
Fiixes: https://trac.macports.org/ticket/68851
Type(s)
Tested on
macOS 12.7.1 21G920 x86_64
Xcode 14.2 14C18
Verification
Have you
port lint --nitpick
?sudo port -vst install
?sudo port -v install
?