Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fgsl: update to 1.5.0 #21729

Closed
wants to merge 2 commits into from
Closed

Conversation

Dave-Allured
Copy link
Contributor

@Dave-Allured Dave-Allured commented Dec 11, 2023

Description

  • Update FGSL 1.4.0 --> 1.5.0.
  • Fix Github download.
  • Fix livecheck.
  • Add to description: Version 1.5.x is for use with GSL versions >= 2.6.
  • Add direct link to upstream github repo.
  • Add myself as co-maintainer.

Fiixes: https://trac.macports.org/ticket/68851

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.7.1 21G920 x86_64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried a full install with sudo port -vst install?
  • tried a full install with sudo port -v install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

.

* Update FGSL 1.4.0 --> 1.5.0.
* Fix Github download.
* Fix livecheck.
* Add to description: Version 1.5.x is for use with GSL versions >= 2.6.
* Add direct link to upstream github repo.
* Add myself as co-maintainer.

Fiixes: https://trac.macports.org/ticket/68851
@macportsbot
Copy link

Notifying maintainers:
@tenomoto for port fgsl.

math/fgsl/Portfile Outdated Show resolved Hide resolved
@herbygillot
Copy link
Member

Can you squash the homepage commit into your original commit? As per guidelines, MacPorts likes to see one commit for updates to a particular port where possible:

https://trac.macports.org/wiki/CommitMessages

@Dave-Allured Dave-Allured mentioned this pull request Dec 12, 2023
12 tasks
@Dave-Allured
Copy link
Contributor Author

Can you squash the homepage commit into your original commit? As per guidelines, MacPorts likes to see one commit for updates to a particular port where possible:

https://trac.macports.org/wiki/CommitMessages

Done. Transfer to new PR: #21746

@reneeotten
Copy link
Contributor

@Dave-Allured please do not close PRs and open new ones for trivial changes like squashing commits.

@Dave-Allured
Copy link
Contributor Author

@reneeotten Sorry. I use github.com exclusively for security reasons. Github does not provide squash. New PR is the only way I know to comply with squash requests. Your advice? Can you talk github into adding squash?

@reneeotten
Copy link
Contributor

@reneeotten Sorry. I use github.com exclusively for security reasons. Github does not provide squash. New PR is the only way I know to comply with squash requests. Your advice? Can you talk github into adding squash?

what's wrong / insecure of using git on your command line like the rest of the world does ;) ?

@Dave-Allured
Copy link
Contributor Author

Git is a direct network link between the word and inside my agency's corporate firewall. We have strong security policies. I have no faith in git security. I do not know what it does on the inside. I have no reason to push that firewall if I can work around using github on browser.

@herbygillot
Copy link
Member

Git has the concept of local and remote branches.

When you make a change, and you do a git add, followed by a git commit, you are creating commits on the local branch on your workstation.

So then when you do a git push, you are then pushing your local branch onto its remote counterpart, which is hosted in Github.

What we mean when we say that you can squash commits is that you can use the git rebase command locally to combine commits or rework the commits in your local branch. This is a way in which you can reduce multiple commits back down to a single commit, which still incorporates all the changes from all the commits.

Then you would do whats called a force push (git push -f), and this would overwrite the remote branch in Github with your newly amended local branch.

In this way, you can squash the commits on the branch of your pull request without having to close the pull request and open a brand new one using a brand new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: update
5 participants