Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collectd: Disable -Werror #21784

Merged
merged 1 commit into from
Dec 14, 2023
Merged

collectd: Disable -Werror #21784

merged 1 commit into from
Dec 14, 2023

Conversation

neverpanic
Copy link
Member

Description

Closes: https://trac.macports.org/ticket/68896

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.2 23C64 arm64
Xcode 15.0.1 15A507

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@raimue for port collectd.

@macportsbot macportsbot added type: bugfix maintainer maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Dec 14, 2023
raimue
raimue approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@raimue raimue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@neverpanic neverpanic merged commit 2e8b574 into macports:master Dec 14, 2023
3 checks passed
@neverpanic neverpanic deleted the cal-68896 branch December 14, 2023 20:32
@FranklinYu
Copy link
Contributor

Thanks for fixing this so promptly! This version builds flawlessly on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimue raimue raimue approved these changes

Assignees

@raimue raimue

Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer type: bugfix
Milestone
No milestone
4 participants
@neverpanic @macportsbot @FranklinYu @raimue