Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdf5: Avoid duplicate LC_RPATH's #21962

Merged
merged 1 commit into from
Dec 28, 2023
Merged

hdf5: Avoid duplicate LC_RPATH's #21962

merged 1 commit into from
Dec 28, 2023

Conversation

Dave-Allured
Copy link
Contributor

Description

  • Avoid duplicate LC_RPATH's in hdf5 fortran dylibs, using new compiler PG option.
  • Rev bump to push out the corrected dylibs.

This PR attempts to fix builds for dependent ports on Ventura and Sonoma, with Xcode 15. The Xcode 15 linker has a new rule against duplicate LC_RPATH's. Rev bump is needed to push out the corrected dylibs.

This is a follow-up to the recent PR #21946 which tried but failed to fix the same problem with port hdf5.

The fix for duplicate LC_RPATH's was copied from the recent OpenBLAS fix for the same thing: #21765

Type(s)
  • bugfix
Tested on

macOS 12.7.1 21G920 x86_64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tried a full install with port -vs install?
  • tested basic functionality of all binary files?
  • tested basic functionality of ONE binary files?
  • checked that the Portfile's most important variants haven't been broken?

@Dave-Allured
hdf5: Avoid duplicate LC_RPATH's
7ed0676 
.

* Avoid duplicate LC_RPATH's in hdf5 fortran dylibs, using new compiler PG option.
* Rev bump to push out the corrected dylibs.

This PR attempts to fix builds for dependent ports on Ventura and Sonoma, with Xcode 15.  The Xcode 15 linker has a new rule against duplicate LC_RPATH's.  Rev bump is needed to push out the corrected dylibs.

The fix for duplicate LC_RPATH's was copied from the recent OpenBLAS fix for the same thing:
macports#21765
@macportsbot
Copy link

Notifying maintainers:
@eborisch for port hdf5.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Dec 28, 2023
@eborisch eborisch merged commit 6a74062 into macports:master Dec 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eborisch eborisch

Labels
maintainer: open Affects an openmaintainer port type: bugfix
Milestone
No milestone
3 participants
@Dave-Allured @macportsbot @eborisch