GtkWave : Update gtkwave to 3.3.117

[langly]

Description

Updated GtkWave from 3.3.115 to 3.3.117.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 14.0 23A344 arm64
Xcode 15.2 15C500b

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[pmetzger]

CI failed.

[langly]

I saw. Seems like it's falling over on one of the dependencies. I'll check later.

[langly]

Ah, yeah. Found some time to look at it now. The problem is not in this Portfile, for the macos-11 build, but in gtk-osx-application-common-gtk3.

From the logfiles:

DEBUG: Using compiler 'Xcode Clang'
DEBUG: Executing proc-pre-org.macports.configure-configure-0
DEBUG: Active variants check for source-type install considers depends_fetch depends_extract depends_lib depends_build depends_run: xz gtk3 pkgconfig
DEBUG: Executing proc-pre-org.macports.configure-configure-1
DEBUG: gtk3 is installed with the following variants: +x11
DEBUG:   required: quartz, forbidden:
DEBUG:   rejected, because required variant quartz is missing
Error:
gtk-osx-application-common-gtk3 is meant to be used only in a GTK quartz
development environment but your version of GTK does not
support quartz.  Please make sure that port gtk3 and all its
dependencies are built with variants +quartz and try again.

Error: Failed to configure gtk-osx-application-common-gtk3: gtk3 +quartz not installed.
DEBUG: Error code: NONE
DEBUG: Backtrace: gtk3 +quartz not installed.

[pmetzger]

Is that the default variant?

[pmetzger]

CI is still failing.

[ryandesign]

CI is still failing.

CI will never succeed because this port depends on gtk-osx-application-common-gtk3 which depends on the +quartz variant of gtk3 which is not the default variant. So we cannot rely on CI results when deciding how to proceed with this PR.

[pmetzger]

Well, then we'll need the submitter to still fix any remaining issues above. @reneeotten are you happy at this point?

[reneeotten]

Please do not remove "--disable-silent-rules"

[reneeotten]

this should remain disabled - or is it not a configure argument anymore?

[langly]

I added back the disable-silent-rules.