openjdk8: add libiconv as run dependency #22230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying maintainers: |
jmroot
reviewed
Jan 18, 2024
| @@ -50,6 +50,7 @@ depends_build port:autoconf \ | |||
| port:gmake \ | |||
| port:pkgconfig \ | |||
| port:bash | |||
| depends_run port:libiconv | |||
There was a problem hiding this comment.
According to other people responding to https://trac.macports.org/ticket/68278 depends_run would be ok, but I don't know if the library just needs to be present at runtime, or if its presence has an effect on the build process.
There was a problem hiding this comment.
Normally a library has to be present in order to link with it. Some of the build-time dependencies depend on libiconv, so it would already have been present when building, just not deliberately.
There was a problem hiding this comment.
Ok, I've created #22261 for openjdk8. Will do the same for the other major versions later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
libiconvas a run dependency to fix https://trac.macports.org/ticket/68278 foropenjdk8.Type(s)
Tested on
macOS 14.2.1 23C71 arm64
Xcode 15.2 15C500b
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?