prelude-manager: Use MacPorts libev and net-snmp #22332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes build failure on recent macOS whose net-snmp-config is broken. Closes: https://trac.macports.org/ticket/69153 Switch pkgconfig dependency to path:-based to accommodate pkgconf. Add libtool dependency because prelude-manager links with libltdl.dylib. Add net-snmp dependency and --enable-snmp configure arg for clarity. Add libev dependency and --with-libev configure arg to tell it to use MacPorts libev and patch Makefile.am to avoid trying to build the bundled libev which would fail. Add LIBEV_CFLAGS and LIBEV_LIBS environment variables because the configure script expects to find libev via pkg-config but libev doesn't provide a pkg-config file. Remove --mandir=${prefix}/share/man configure arg; that's the default. Add --with-libwrap=${prefix} configure arg to suppress an ld warning that otherwise appears due to an improperly written configure script. Suppress warning about intentional implicit declaration of strchr. Use destroot.keepdirs to create the turd file in ${destroot}${prefix} /var/spool/prelude-manager rather than doing it manually. Co-authored-by: Craig Treleaven <ctreleaven@macports.org>
|
Notifying maintainers: |
macportsbot
added
maintainer: open
|
Thank you Ryan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes build failure on recent macOS whose net-snmp-config is broken.
Closes: https://trac.macports.org/ticket/69153
Switch pkgconfig dependency to path:-based to accommodate pkgconf.
Add libtool dependency because prelude-manager links with libltdl.dylib.
Add net-snmp dependency and --enable-snmp configure arg for clarity.
Add libev dependency and --with-libev configure arg to tell it to use MacPorts libev and patch Makefile.am to avoid trying to build the bundled libev which would fail. Add LIBEV_CFLAGS and LIBEV_LIBS environment variables because the configure script expects to find libev via pkg-config but libev doesn't provide a pkg-config file.
Remove --mandir=${prefix}/share/man configure arg; that's the default.
Add --with-libwrap=${prefix} configure arg to suppress an ld warning that otherwise appears due to an improperly written configure script.
Suppress warning about intentional implicit declaration of strchr.
Use destroot.keepdirs to create the turd file in ${destroot}${prefix}/var/spool/prelude-manager rather than doing it manually.
Type(s)
Tested on
macOS 12.7.2 21G1974 x86_64
Xcode 14.2 14C18
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vst install?