Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btop: update to 1.3.0, cleanup portfile #22412

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

i0ntempest
Copy link
Member

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@Samasaur1 for port btop.

@macportsbot macportsbot added type: enhancement type: update maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Jan 27, 2024
sysutils/btop/Portfile Show resolved Hide resolved
@Samasaur1
Copy link
Contributor

We should also be able to use Apple's clang bundled with Xcode 15, since despite reporting a clang version of Apple clang version 15.0.0 (clang-1500.1.0.2.5), it actually uses LLVM 16, which is the version necessary for btop. Unfortunately, the minimum versions of clang that MacPorts thinks is necessary for C++20 does not support ranges, the C++20 feature that btop needs, so we will need to maintain the list of blacklisted compilers.

@Samasaur1
Copy link
Contributor

But that can be for a future improvement to the Portfile — once the epoch 1 change is made, this PR looks ready to merge in my opinion

@i0ntempest
Copy link
Member Author

Epoch addition has been pushed

@reneeotten reneeotten merged commit e004c4c into macports:master Jan 28, 2024
3 checks passed
@i0ntempest i0ntempest deleted the btop branch January 28, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: enhancement type: update
4 participants