Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abseil: update to 20240116.0 #22481

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

herbygillot
Copy link
Member

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@barracuda156 for port s2geometry.
@neverpanic for port Bear.
@judaew for port abseil.
@mascguy for port protobuf3-cpp-upstream.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Jan 31, 2024
Copy link
Member

@judaew judaew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution ✨

Copy link
Contributor

@barracuda156 barracuda156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abseil 20240116.0 builds fine on PowerPC for me.

With regard to s2geometry I rely on CI.

devel/abseil/Portfile Outdated Show resolved Hide resolved
@pmetzger
Copy link
Member

pmetzger commented Feb 1, 2024

@neverpanic You okay with merging?

Copy link
Member

@neverpanic neverpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. In fact the revbump of Bear should no longer required due to the changes we made in re2 IIRC, but it also doesn't hurt.

@herbygillot herbygillot merged commit 16e6491 into macports:master Feb 1, 2024
3 checks passed
@herbygillot
Copy link
Member Author

Thank you all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: update
7 participants