Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkl: new port (version 0.25.1) #22592

Merged
merged 1 commit into from
Feb 13, 2024
Merged

pkl: new port (version 0.25.1) #22592

merged 1 commit into from
Feb 13, 2024

Conversation

subpop
Copy link
Contributor

@subpop subpop commented Feb 7, 2024

Description

Add https://www.pkl-lang.org

Type(s)
  • submission
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.2.1 23C71 arm64
Xcode 15.2 15C500b

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • [-] tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subpop a few comments with the acknowledgement I know nothing about Java...

lang/pkl/Portfile Show resolved Hide resolved
lang/pkl/Portfile Outdated Show resolved Hide resolved
lang/pkl/Portfile Outdated Show resolved Hide resolved
lang/pkl/Portfile Show resolved Hide resolved
lang/pkl/Portfile Show resolved Hide resolved
lang/pkl/Portfile Show resolved Hide resolved
lang/pkl/Portfile Outdated Show resolved Hide resolved
@subpop subpop force-pushed the add-pkl branch 4 times, most recently from 1ebb84e to 1da80c4 Compare February 8, 2024 18:51
@pmetzger
Copy link
Member

@reneeotten Are you happier at this point?

@mascguy mascguy self-assigned this Feb 13, 2024
Signed-off-by: Link Dupont <link@sub-pop.net>
Copy link
Member

@mascguy mascguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mascguy
Copy link
Member

mascguy commented Feb 13, 2024

And thank you so much for the contribution @subpop !

@mascguy mascguy merged commit 5df51ac into macports:master Feb 13, 2024
4 checks passed
@subpop subpop deleted the add-pkl branch February 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants