p5-dbd-mysql: cleanup variant listing and fix mariadb/percona #22718
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Portfile to reduce the redundant work needed to update
variants.
Additionally, in version >5 support for databases other than the
mysql8x was dropped. Fix broken mariadb and percona variants by
pointing them to an older version (4). These versions will need to
be pruned when they go EOL. Mariadb based ports should start to
migrate to using p5-dbd-mariadb
Description
Basically, the old portfile was very manually intensive to update leading to lots of place where a small detail could be missed causing errors. This update automates many of those issues.
Additionally, DBD:mysql versions greater than 5 no longer support SQL variants other than mysql8+. As such, have the portfile install v5+ for mysql8+ variants and install the older v4 for mariadb / percona.
When those versions of mariadb/percona retire, this workaround should be removed from the portfile.
Users need to suggest to their upstream counterparts to move away from DBD:mysql for mariadb and percona based installs.
Reference Trac ticket 69359 for additional details on how we got here.
Type(s)
Tested on
macOS 14.3.1 23D60 x86_64
Xcode 15.2 15C500b
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?