Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octave-gsl: Add missing patchfile #22787

Closed
wants to merge 1 commit into from

Conversation

ryandesign
Copy link
Contributor

Description

Fixes "fatal error: 'ov-scalar.h' file not found" which occurred due to failure to locate Octave's include directory.

Closes: https://trac.macports.org/ticket/69246

Instead of adding the nearly 4000-line configure patch, I added the much smaller configure.ac.in patch and then made the port run bootstrap to regenerate configure.ac and configure.

This built for me on macOS 12 x86_64, but it also worked for me before this change, so we need to see if it works in CI and Marius you may want to test it on your system as well.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.7.2 21G1974 x86_64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Fixes "fatal error: 'ov-scalar.h' file not found" which occurred due to
failure to locate Octave's include directory.

Closes: https://trac.macports.org/ticket/69246
@macportsbot
Copy link

Notifying maintainers:
@Schamschula for port octave-gsl.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Feb 23, 2024
@ryandesign
Copy link
Contributor Author

Fixes "fatal error: 'ov-scalar.h' file not found" which occurred due to failure to locate Octave's include directory.

Closes: https://trac.macports.org/ticket/69246

Based on the CI build failure on macOS 14 arm64 this unfortunately hasn't fixed it:

checking for Octave's canonical_host_type... fatal: caught signal Trace/BPT trap: 5 -- stopping myself...

checking for Octave's include directory... fatal: caught signal Trace/BPT trap: 5 -- stopping myself...

checking for ov-scalar.h... no
configure: error: ov-scalar.h header not found

On my Mac I noticed that when it was checking for these two things, the Terminal window deactivated, as if it's trying to run some GUI thing to make these determinations. That seems doomed to fail. It shouldn't need to start a GUI to find its include directory and host type.

@reneeotten
Copy link
Contributor

@Schamschula do you want to merge this or go for another solution? If you don't want/need this PR please close.

@Schamschula
Copy link
Contributor

Unfortunately, the issue where it starts a GUI session happens while attempting to install several other octave packages as well.

The gsl package issue has not been fixed upstream.

See: https://savannah.gnu.org/bugs/index.php?61668

@ryandesign
Copy link
Contributor Author

Closing. This doesn't fix the issue. Nobody develops this software anymore so it will never be fixed.

@ryandesign ryandesign closed this May 13, 2024
@ryandesign ryandesign deleted the octave-gsl branch May 13, 2024 22:42
@Schamschula
Copy link
Contributor

Agreed!

@Schamschula
Copy link
Contributor

I probably should remove the Portfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
4 participants