Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yq: documentation & completion #22893

Merged
merged 1 commit into from
Mar 21, 2024
Merged

yq: documentation & completion #22893

merged 1 commit into from
Mar 21, 2024

Conversation

danchr
Copy link
Member

@danchr danchr commented Mar 4, 2024

Description

Partly inspired by the Debian rules, which also include a manual page and the license file. While at it, I also added shell completion and the bundled examples.

I included a patch to suppress an issue where showing the manual which trigger a warning:

$ man yq
This manpage is not compatible with mandoc(1) and might display incorrectly.
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Partly inspired by the Debian rules, which also include a manual page
and the license file. While at it, I also added shell completion and the
bundled examples.
@macportsbot
Copy link

Notifying maintainers:
@herbygillot for port yq.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Mar 4, 2024
@herbygillot
Copy link
Member

It looks like the depends_build statement you added for pandoc is overwriting the one implicitly set by the golang portgroup.

Try changing it to depends_build-append.

@mascguy
Copy link
Member

mascguy commented Mar 5, 2024

It looks like the depends_build statement you added for pandoc is overwriting the one implicitly set by the golang portgroup.

Try changing it to depends_build-append.

Yep, this explains why go isn't being found:

sh: /opt/local/bin/go: No such file or directory

@danchr
Copy link
Member Author

danchr commented Mar 5, 2024

It looks like the depends_build statement you added for pandoc is overwriting the one implicitly set by the golang portgroup.

Try changing it to depends_build-append.

Ah, sorry, what a rookie mistake 😁 Fixed!

@mascguy
Copy link
Member

mascguy commented Mar 5, 2024

It looks like the binaries for pandoc may be stale:

dyld[3845]: Library not loaded: /opt/local/lib/libz.1.dylib

Referenced from: /opt/local/bin/pandoc

@herbygillot
Copy link
Member

It looks like the binaries for pandoc may be stale:

dyld[3845]: Library not loaded: /opt/local/lib/libz.1.dylib

Referenced from: /opt/local/bin/pandoc

This looks like pandoc needs an explicit dependency listed for zlib, which it currently doesn't have: https://ports.macports.org/port/pandoc/details/

@danchr
Copy link
Member Author

danchr commented Mar 13, 2024

Oddly enough, the build still fails on macOS 14? 🤔

@herbygillot
Copy link
Member

Oddly enough, the build still fails on macOS 14? 🤔

I think we're still seeing issues with pandoc, unfortunately.

@herbygillot herbygillot mentioned this pull request Mar 18, 2024
9 tasks
@danchr danchr closed this Mar 18, 2024
@danchr danchr deleted the yq branch March 18, 2024 15:25
@danchr danchr restored the yq branch March 21, 2024 13:10
@danchr danchr reopened this Mar 21, 2024
@danchr danchr merged commit 38ad883 into macports:master Mar 21, 2024
4 checks passed
@danchr danchr deleted the yq branch March 21, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: enhancement
4 participants