opensmtpd: fix build on older systems (back-port upstream patch)

[barracuda156]

Description

Pick a fix suggested by upstream.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.4.11
Xcode 2.5

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL in commit message?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[macportsbot]

Notifying maintainers:
@ryanakca for port opensmtpd.

[barracuda156]

@ryanakca Error with running tests cannot possibly be related to my fix here (which does nothing for 10.7+).

  --->  Testing opensmtpd
  Error: Failed to test opensmtpd: /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_mail_opensmtpd/opensmtpd/work/destroot/opt/local/var/spool/smtpd: permission denied
  DEBUG: Error code: POSIX EACCES {permission denied}
  DEBUG: Backtrace: /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_mail_opensmtpd/opensmtpd/work/destroot/opt/local/var/spool/smtpd: permission denied
      while executing
  "fs-traverse -depth fullpath [list [option destpath]] {
          if {[file type $fullpath] ne "file"} {
              continue
          }
          if {[file..."
      (procedure "porttest::test_archs" line 11)
      invoked from within
  "porttest::test_archs"
      (procedure "porttest::test_main" line 5)
      invoked from within
  "$procedure $targetname"
  Error: See /opt/local/var/macports/logs/_Users_runner_work_macports-ports_macports-ports_ports_mail_opensmtpd/opensmtpd/main.log for details.
  Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
  Error: Processing of port opensmtpd failed
  Testing 'opensmtpd' failed.
  /Users/runner/work/macports-ports/macports-ports/mpbb/mpbb: error: `test-port' failed to run successfully

[barracuda156]

Has been merged in upstream master in OpenSMTPD/OpenSMTPD@276e064

[barracuda156]

@pmetzger @reneeotten Could we please merge this regardless of CI? I am not interested to deal with fixing tests here, this is not my port. CI failure is unrelated to this PR, and the only thing my PR does is to add a patch suggested by and already merged to upstream.

[reneeotten]

@barracuda156 as usual we'll give the maintainer some time to take a look at the proposed changes first.

[barracuda156]

@barracuda156 as usual we'll give the maintainer some time to take a look at the proposed changes first.

Sure, of course.