Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8-11.6: new port in lang #22943

Merged
merged 1 commit into from
Mar 13, 2024
Merged

v8-11.6: new port in lang #22943

merged 1 commit into from
Mar 13, 2024

Conversation

barracuda156
Copy link
Contributor

Closes: https://trac.macports.org/ticket/69351

Description

New version of V8.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.3.1
Xcode 15.3

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@ryandesign
Copy link
Contributor

ryandesign commented Mar 8, 2024

Thank you, but this doesn't appear to be an improvement over the v8-8.3 port, other than in version number. It still uses the v8-cmake fork which still doesn't install shared libraries nor install a single libv8 library that downstream software expects. If we're going to offer v8 in MacPorts, we should offer v8, not some nonstandard fork.

Closes: https://trac.macports.org/ticket/69351

It's unrelated to that ticket, which was a request to update v8-8.3 to the latest 8.3.x version and fix its livecheck, neither of which this PR addresses. Of course, if you plan to discontinue v8-8.3 and replace it with v8-11.6, then I suppose this PR can close that ticket.

@barracuda156
Copy link
Contributor Author

barracuda156 commented Mar 8, 2024

@ryandesign I have removed “Closes ticket” note now.

As for dynamic libs, a) it should be possible to support them via CMake, once someone has time and desire to (not required for my purposes, since static libs work fine); b) it is possible to switch the build system at any point, once someone implements the build via gn (I am fine with that, and can share or pass maintanership in such a case).

Not planning to retire 8.x, but if you prefer not having minor versioning, we can rename these to v8-8 and v8-11.
(It is worth having at least major versions as separate ports.)

@barracuda156
Copy link
Contributor Author

@herbygillot @pmetzger Could we merge this one? While this does not yet close a related ticket, this is a definite improvement (by the way, not for PowerPC, but for modern archs): it introduces a newer version of V8.

@herbygillot herbygillot merged commit c51f6dc into macports:master Mar 13, 2024
4 checks passed
@barracuda156 barracuda156 deleted the v8-11 branch March 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants