Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmp: Use MacPorts m4 #22985

Merged
merged 1 commit into from Mar 13, 2024
Merged

gmp: Use MacPorts m4 #22985

merged 1 commit into from Mar 13, 2024

Conversation

ryandesign
Copy link
Contributor

Description

Xcode 15.3 CLT doesn't include m4, possibly due to an oversight.

Closes: https://trac.macports.org/ticket/69464

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.7.2 21G1974 x86_64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Xcode 15.3 CLT doesn't include m4, possibly due to an oversight.

Closes: https://trac.macports.org/ticket/69464
@macportsbot
Copy link

Notifying maintainers:
@MarcusCalhoun-Lopez for port gmp.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Mar 12, 2024
@barracuda156
Copy link
Contributor

@ryandesign Has Macports m4 been fixed for Leopard?

@ryandesign
Copy link
Contributor Author

I didn't remember that m4 was broken on Leopard. If you're referring to one of the open tickets about m4, then, since they're still open, I guess not.

@MarcusCalhoun-Lopez
Copy link
Contributor

I believe adding use_xcode yes also fixes the problem but without adding a new dependency.

@barracuda156
Copy link
Contributor

I believe adding use_xcode yes also fixes the problem but without adding a new dependency.

Should it be conditionally on OS version?

@ryandesign
Copy link
Contributor Author

Yes, using the full Xcode would work. I think that would be large and unnecessary, however.

The CLT also still includes gm4 which is the same program as m4 so we could use that.

But for consistency and to receive all available bug fixes, performance enhancements, and other improvements, I suggest always depending on the m4 port and forgetting about what Xcode and/or the CLT may provide.

@MarcusCalhoun-Lopez
Copy link
Contributor

But for consistency and to receive all available bug fixes, performance enhancements, and other improvements, I suggest always depending on the m4 port and forgetting about what Xcode and/or the CLT may provide.

I have no strong feelings on the matter, but gmp is an important part of supporting older systems.
I have not looked into m4 specifically, but having gmp with as few dependencies as possible tends to make supporting older systems easier.

@ryandesign
Copy link
Contributor Author

Do as you will, but m4 is a pretty basic utility. It's needed by autoconf, for example, and autoconf no longer supports the pre-GPL-3 version of m4 Apple ships. And m4 only depends on gettext and libiconv which are pretty foundational as well; not much is going to build if gettext and libiconv don't build.

@MarcusCalhoun-Lopez
Copy link
Contributor

Do as you will, but m4 is a pretty basic utility. It's needed by autoconf, for example, and autoconf no longer supports the pre-GPL-3 version of m4 Apple ships. And m4 only depends on gettext and libiconv which are pretty foundational as well; not much is going to build if gettext and libiconv don't build.

Thank you for the insight.

@MarcusCalhoun-Lopez MarcusCalhoun-Lopez merged commit c50b7da into macports:master Mar 13, 2024
4 checks passed
@ryandesign ryandesign deleted the gmp branch March 13, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
4 participants