Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvtop: new port (v3.1.0) #23004

Merged
merged 1 commit into from
Mar 17, 2024
Merged

nvtop: new port (v3.1.0) #23004

merged 1 commit into from
Mar 17, 2024

Conversation

herbygillot
Copy link
Member

https://github.com/Syllo/nvtop

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test sudo port -d destroot?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot macportsbot added type: submission by: member Created by a member with commit rights labels Mar 13, 2024
@ryandesign
Copy link
Contributor

CI succeeded on macOS 13 and 14 but failed on macOS 11 because error: use of undeclared identifier 'kIOMainPortDefault'. Indeed according to Apple documentation kIOMainPortDefault was introduced in macOS 12. Could you indicate this with platforms {darwin >= 21}?

@ryandesign
Copy link
Contributor

I filed an upstream bug report: Syllo/nvtop#284

@herbygillot
Copy link
Member Author

platforms {darwin >= 21}

Added, thanks for taking a look

@pmetzger pmetzger merged commit 07ff46e into macports:master Mar 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights type: submission
4 participants