Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poppler,poppler-devel: use MP libc++ on legacy #23035

Merged
merged 1 commit into from Mar 16, 2024

Conversation

erikbs
Copy link
Contributor

@erikbs erikbs commented Mar 14, 2024

Fixes: https://trac.macports.org/ticket/69455

Description

Fix liking on older Mac OS X versions by linking against MacPorts libc++ on platforms that use the MacPorts legacy-support library

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.9.5 13F1911 x86_64
Xcode 6.2 6C131e

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@mascguy for port poppler-devel, poppler.
@dbevans for port poppler-devel, poppler.

@ryandesign
Copy link
Contributor

Don't you also need to add legacysupport.newest_darwin_requires_legacy 18?

@erikbs
Copy link
Contributor Author

erikbs commented Mar 14, 2024

Yes, I think you are right. The default value seems to be 16, and 19 is the earliest version that provides std::filesystem::path. I pushed an update.

@kencu kencu merged commit b6d032d into macports:master Mar 16, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: enhancement
6 participants