Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnatpmp: new port in net #23276

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

edilmedeiros
Copy link
Contributor

@edilmedeiros edilmedeiros commented Mar 30, 2024

Description

libnatpmp is a dependency for bitcoin core for folks that are building from source. The current bitcoin port does not support libnatpmp. This port opens the possibility of adding a new feature to the bitcoin port.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.7.1 21G920 x86_64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Additional info

Bitcoin Core v26 was successfully compiled from source and tested with the library provided by this port.

@edilmedeiros edilmedeiros changed the title libnatpmp: new Portfile in net libnatpmp: new port in net Mar 30, 2024
libnatpmp is a dependency for bitcoin core for folks that are building from
source. The current bitcoin port does not support libnatpmp. This port opens the
possibility of adding a new feature to the bitcoin port.
@herbygillot herbygillot merged commit 8b4351b into macports:master Apr 1, 2024
4 checks passed
@herbygillot
Copy link
Member

Thanks @edilmedeiros

@edilmedeiros edilmedeiros deleted the add-libnatpmp branch June 9, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants