Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

po4a: update to 0.72 #23327

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

po4a: update to 0.72 #23327

wants to merge 2 commits into from

Conversation

i0ntempest
Copy link
Member

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot macportsbot added type: update maintainer: none by: member Created by a member with commit rights labels Apr 2, 2024
@i0ntempest i0ntempest marked this pull request as draft April 3, 2024 04:48
@i0ntempest
Copy link
Member Author

i0ntempest commented Apr 3, 2024

It looks like the system Perl is slipping in and causing build failures, as can be seen from the include paths:

po4a::chooser: Module loading error: Can't locate Pod/Parser.pm in @INC (you may need to install the Pod::Parser module) (@INC contains: lib /Library/Perl/5.34/darwin-thread-multi-2level /Library/Perl/5.34 /Network/Library/Perl/5.34/darwin-thread-multi-2level /Network/Library/Perl/5.34 /Library/Perl/Updates/5.34.1 /System/Library/Perl/5.34/darwin-thread-multi-2level /System/Library/Perl/5.34 /System/Library/Perl/Extras/5.34/darwin-thread-multi-2level /System/Library/Perl/Extras/5.34) at lib/Locale/Po4a/Pod.pm line 14.

This happens with 0.69 as well. I tried patching all /usr/bin/perl and /usr/bin/env perl out to no avail. Need a bit of help here.
Having perl5 +perl5_34 installed will allow the port to build.

@i0ntempest i0ntempest changed the title po4a: update to 0.71 [Help needed] po4a: update to 0.71 Apr 3, 2024
@i0ntempest i0ntempest marked this pull request as ready for review April 3, 2024 05:28
@ryandesign
Copy link
Contributor

po4a::chooser: Module loading error: Can't locate Pod/Parser.pm in @INC (you may need to install the Pod::Parser module) (@INC contains: lib /Library/Perl/5.34/darwin-thread-multi-2level /Library/Perl/5.34 /Network/Library/Perl/5.34/darwin-thread-multi-2level /Network/Library/Perl/5.34 /Library/Perl/Updates/5.34.1 /System/Library/Perl/5.34/darwin-thread-multi-2level /System/Library/Perl/5.34 /System/Library/Perl/Extras/5.34/darwin-thread-multi-2level /System/Library/Perl/Extras/5.34) at lib/Locale/Po4a/Pod.pm line 14.

This is only happening on the macOS 14 runner.

On the macOS 11, 12, and 13 runners, and locally on my macOS 12 machine, this happens instead:

Malformed encoding while writing to file /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_textproc_po4a/po4a/work/po4a-0.71/blib/man/ca/man3/Locale::Po4a::Xml.3pm.pod with charset UTF-8: "\x{fffd}" does not map to UTF-8 at lib/Locale/Po4a/TransTractor.pm line 513.

@ryandesign
Copy link
Contributor

This is only happening on the macOS 14 runner.

Might be worth rechecking after fixes for https://trac.macports.org/ticket/69661 happen.

@reneeotten reneeotten marked this pull request as draft April 4, 2024 00:59
@i0ntempest i0ntempest force-pushed the po4a branch 2 times, most recently from 1328a9a to f37aeab Compare May 25, 2024 22:57
@i0ntempest i0ntempest changed the title [Help needed] po4a: update to 0.71 [Help needed] po4a: update to 0.72 May 25, 2024
@i0ntempest i0ntempest marked this pull request as ready for review May 25, 2024 23:37
@i0ntempest
Copy link
Member Author

I've added a workaround. Despite the different errors on different systems it seems to have fixed both. Please take another look.

@i0ntempest i0ntempest changed the title [Help needed] po4a: update to 0.72 po4a: update to 0.72 May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: none type: update
3 participants