Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openimageio: update to 2.5.10.1 #23455

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

mohd-akram
Copy link
Member

Description

  • use python312 and drop EOL python
  • use onetbb

Closes: https://trac.macports.org/ticket/67646

Tested on

macOS 14.4.1 23E224 x86_64
Xcode 15.3 15E204a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@MarcusCalhoun-Lopez for port openimageio.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port labels Apr 11, 2024
@mascguy
Copy link
Member

mascguy commented Apr 11, 2024

Unfortunately I'm not able to test this update against dependents, but are you sure there isn't any breakage due to dylib name changes...?

@mascguy
Copy link
Member

mascguy commented Apr 11, 2024

CCing @jasonliu-- , since this is a foundational component for Jason's various ports (blender, embree, materialx, etc).

- use python312 and drop EOL python
- use onetbb

Closes: https://trac.macports.org/ticket/67646
@mohd-akram
Copy link
Member Author

$ port echo depends:openimageio
blender                         
embree                          
materialx                       
oidn                            
osl

Looking at the port health, blender, materialx and osl are currently broken, so I have no idea if they need a bump or not. embree installs fine (it doesn't seem to reference the openimageio dylib), and oidn needs a bump. These ports are all pretty outdated.

Copy link
Member

@mascguy mascguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on deleted patch

@mohd-akram
Copy link
Member Author

Failure is unrelated to the port.

@mascguy
Copy link
Member

mascguy commented Apr 13, 2024

I'm good with the changes, but ultimately I'll defer to Marcus.

@mohd-akram mohd-akram merged commit 41c2d0d into macports:master Apr 18, 2024
3 of 4 checks passed
@mohd-akram mohd-akram deleted the openimageio branch April 18, 2024 10:51
@mohd-akram
Copy link
Member Author

Thanks @mascguy. Merged due to maintainer timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: update
4 participants