Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draco: patch cmake to not use --start-group ,--end-group on mac #23516

Merged
merged 1 commit into from
Apr 15, 2024
Merged

draco: patch cmake to not use --start-group ,--end-group on mac #23516

merged 1 commit into from
Apr 15, 2024

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Apr 15, 2024

Description

Apply patch to not use the linker flags -start-group and --end-group on macOS systems, as noted by Ryan.

Hopefully this finally closes https://trac.macports.org/ticket/69719.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@ryandesign ryandesign merged commit 4db533b into macports:master Apr 15, 2024
4 checks passed
@nilason nilason deleted the draco_cmake_patch branch April 16, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintainer: open Affects an openmaintainer port maintainer type: bugfix
Milestone
No milestone
3 participants
@nilason @ryandesign @macportsbot