Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draco: make 'ghc-filesystem' a build dependency #23517

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Apr 15, 2024

Description

Make dracos dependency ghc-filesystem a build dependency.

Closes: https://trac.macports.org/ticket/69738

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're removing a library dependency and should thus increase the "revision"

@nilason
Copy link
Contributor Author

nilason commented Apr 16, 2024

You're removing a library dependency and should thus increase the "revision"

According to MacPorts Guide, that usually shouldn't be needed when

changing a dependency's type, e.g. from depends_lib to depends_build

which is the case here.

@ryandesign ryandesign merged commit 35aa0c5 into macports:master Apr 16, 2024
4 checks passed
@nilason nilason deleted the draco_deps branch April 16, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants