New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mod_tile: Update to proj7, variants to use Postgresql15-16 #23645
base: master
Are you sure you want to change the base?
Conversation
The latest version of |
I've had a cursory look through the commit log since 0.5 and most of the works seems to be on implementing CI and Docker. One or two small bug fixes are mentioned, but I do not immediately see any gains in functionality or security that make it worth the time and effort of upgrading at this time. Feel welcome to do so, but perhaps it would be best if we can implement this PR as a first step, as it does fix current issues, i.e. Launch Daemon for OSM updates will not run on Sonoma and your wonderful work on Mapnik will allow |
This looks good to me (with the caveat I haven't tried it out). The version bump can certainly be a separate/later PR. Suppose this should be merged after/simultaneously with #23420. |
I've tested it against the current port tree and after applying the above PR. It's fine to apply independently. If done after the PR it should have the additional benefit of building on arm64 too. |
CI is failing. |
There's not enough information in the macos-13 CI log for me to determine the cause of failure. It seems to fail on building It seems from the image name that macos-14 is arm64, which will fail to install/build the |
This is quite the case. |
@frankdean Now with #23420 merged, please rebase. |
…h daemon Also create `mapnik.xml.dist` during the build so it longer needs to be distributed with `openstreetmap-cart` port.
Rebased. All CI checks passing. Is this PR OK for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Fixed launch daemon failing to start on macOS 14.4.1 (Sonoma)
Also now creates
mapnik.xml.dist
during the build/install so it longer needs to be distributed with theopenstreetmap-carto
port.Description
Type(s)
Tested on
macOS 14.4.1 23E224 arm64
Xcode 15.3 15E204a
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?@nilason - available for your review and comments.