Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_tile: Update to proj7, variants to use Postgresql15-16 #23645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frankdean
Copy link
Contributor

Fixed launch daemon failing to start on macOS 14.4.1 (Sonoma)

Also now creates mapnik.xml.dist during the build/install so it longer needs to be distributed with the openstreetmap-carto port.

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.4.1 23E224 arm64
Xcode 15.3 15E204a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@nilason - available for your review and comments.

@nilason
Copy link
Contributor

nilason commented Apr 21, 2024

The latest version of mod_tile is 0.7.1, any particular reason not to update? I know there are considerable changes, which is why I still have not finished my work on the port.

@frankdean
Copy link
Contributor Author

frankdean commented Apr 21, 2024

The latest version of mod_tile is 0.7.1, any particular reason not to update? I know there are considerable changes, which is why I still have not finished my work on the port.

I've had a cursory look through the commit log since 0.5 and most of the works seems to be on implementing CI and Docker. One or two small bug fixes are mentioned, but mod_tile has been running fine for me for a few years. Some mention of fixes for macOS, but I suspect we've already applied a working patch.

I do not immediately see any gains in functionality or security that make it worth the time and effort of upgrading at this time. Feel welcome to do so, but perhaps it would be best if we can implement this PR as a first step, as it does fix current issues, i.e. Launch Daemon for OSM updates will not run on Sonoma and your wonderful work on Mapnik will allow mod_tile to run on arm64!

@nilason
Copy link
Contributor

nilason commented Apr 23, 2024

This looks good to me (with the caveat I haven't tried it out). The version bump can certainly be a separate/later PR.

Suppose this should be merged after/simultaneously with #23420.

@frankdean
Copy link
Contributor Author

This looks good to me (with the caveat I haven't tried it out). The version bump can certainly be a separate/later PR.

Suppose this should be merged after/simultaneously with #23420.

I've tested it against the current port tree and after applying the above PR. It's fine to apply independently. If done after the PR it should have the additional benefit of building on arm64 too.

@pmetzger
Copy link
Member

CI is failing.

@frankdean
Copy link
Contributor Author

CI is failing.

There's not enough information in the macos-13 CI log for me to determine the cause of failure. It seems to fail on building openstreetmap-carto +postgresql13, but that port plus variant build fine for me on macOS 14. Is the actual main.log for the port's failed build available anywhere?

It seems from the image name that macos-14 is arm64, which will fail to install/build the mapnik dependency until the above mentioned PR is implemented.

@nilason
Copy link
Contributor

nilason commented Apr 25, 2024

It seems from the image name that macos-14 is arm64, which will fail to install/build the mapnik dependency until the above mentioned PR is implemented.

This is quite the case.

@nilason
Copy link
Contributor

nilason commented Apr 27, 2024

@frankdean Now with #23420 merged, please rebase.

…h daemon

Also create `mapnik.xml.dist` during the build so it longer needs to be
distributed with `openstreetmap-cart` port.
@frankdean
Copy link
Contributor Author

@frankdean Now with #23420 merged, please rebase.

Rebased. All CI checks passing. Is this PR OK for you?

Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants