Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk8: fix initial build errors on powerpc #23844

Closed
wants to merge 7 commits into from

Conversation

barracuda156
Copy link
Contributor

@barracuda156 barracuda156 commented May 6, 2024

Description

CI failures seem irrelevant. All changes are for powerpc, and I have no intention to change anything for any other archs.

This fixes a number of errors which break the build in its early stages. I kept all patches restricted to PowerPC, so revbump should not be needed: changes for other systems are non-functional.

P. S. PPC32 has been used since openjdk/jdk8u@036382c and still used in the current code https://github.com/openjdk/jdk8u/blob/6b53212ef78ad50f9eede829c5ff87cadcdb434b/hotspot/src/os_cpu/bsd_zero/vm/os_bsd_zero.hpp#L39

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@usersxx for port openjdk8.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels May 6, 2024
@barracuda156
Copy link
Contributor Author

Actually wait with merging this, I think I will get it to build as headless.

P. S. The main issue is that source is horribly written, and neither existing nor earlier version of the code works correctly: what we set in configure to ”disable headful” does nothing. It was allegedly addressed in JDK9, however backporting did not work either, or maybe some other commit was needed.
Anyway, I am tired of this pending and will try to sort it in a day or two.

@barracuda156 barracuda156 marked this pull request as draft May 10, 2024 06:53
@reneeotten
Copy link
Contributor

Feel free to reopen once you this is all done.

@reneeotten reneeotten closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
3 participants