Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust update #23874

Merged
merged 2 commits into from
May 21, 2024
Merged

Rust update #23874

merged 2 commits into from
May 21, 2024

Conversation

MarcusCalhoun-Lopez
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot macportsbot added type: enhancement maintainer maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels May 9, 2024
@MarcusCalhoun-Lopez
Copy link
Contributor Author

This PR should probably not be merged until macports/macports-legacy-support#86 is resolved or else Ticket 68015 will continue to be an issue.

@pmetzger
Copy link
Member

Apparently macports/macports-legacy-support#86 is merged, so I will merge this.

@pmetzger pmetzger merged commit d547d0d into macports:master May 21, 2024
4 checks passed
@MarcusCalhoun-Lopez MarcusCalhoun-Lopez deleted the rust_update branch May 21, 2024 14:04
@MarcusCalhoun-Lopez
Copy link
Contributor Author

Apparently macports/macports-legacy-support#86 is merged, so I will merge this.

@pmetzger, while macports/macports-legacy-support#86 has been merged upstream, it has not made it into the MacPorts version.
The upstream maintainers wanted to "allow a bit of time" before doing so.
It is not a big deal, but the new version of Rust from this PR will still be broken on 10.9 and 10.10.

I should have marked this PR as a draft to make it clear this PR was still on hold.

@pmetzger
Copy link
Member

@MarcusCalhoun-Lopez Sorry. What should be done now, then?

@MarcusCalhoun-Lopez
Copy link
Contributor Author

@MarcusCalhoun-Lopez Sorry. What should be done now, then?

I do not think it is a major problem.
Once we get the legacy-support situation worked out, it may be as simple as resubmitting the jobs to the 10.9 and 10.10 buildbots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer type: enhancement
3 participants