Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peg: Downgrade to latest stable version 0.1.19 #24531

Merged
merged 1 commit into from
Jun 21, 2024
Merged

peg: Downgrade to latest stable version 0.1.19 #24531

merged 1 commit into from
Jun 21, 2024

Conversation

ryandesign
Copy link
Contributor

Description

Closes: https://trac.macports.org/ticket/70239

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.7.5 21H1222 x86_64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@herbygillot for port peg.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Jun 18, 2024
@ryandesign ryandesign mentioned this pull request Jun 18, 2024
Closed
@ryandesign
Copy link
Contributor Author

Do not merge yet. Upstream has regenerated the tarballs to remove Subversion metadata. Will need to update checksums and retest.

@ryandesign ryandesign marked this pull request as draft June 18, 2024 21:27
@ryandesign
Copy link
Contributor Author

I've requested that the developer revert their stealth update and am waiting to hear back before updating this PR further.

I have changes staged locally to fix the livecheck and clean up the portfile in other ways.

@ryandesign
peg: Downgrade to latest stable version 0.1.19
6cbf4e3 
Fix livecheck to only see stable versions.

Closes: https://trac.macports.org/ticket/70239

Remove unnecessary patching; use makefile.override, destroot.destdir and
destroot.args instead.
@ryandesign ryandesign marked this pull request as ready for review June 19, 2024 00:22
@ryandesign
Copy link
Contributor Author

The developer reverted the stealth update and intends not to make them in the future.

@pmetzger
Copy link
Member

CI failed on '14.

@ryandesign
Copy link
Contributor Author

Ignore it. It failed to download the distfile from the upstream server. It also happened on the first try on a different runner. I assume the upstream server is configured with some DDoS protection that prohibits more than two connections from a particular subnet within a short time.

@ryandesign
Copy link
Contributor Author

I retried the macos-14 build and it eventually succeeded.

@pmetzger pmetzger merged commit e6f3f6d into macports:master Jun 21, 2024
3 checks passed
@ryandesign ryandesign deleted the peg branch June 22, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@herbygillot herbygillot

Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
Milestone
No milestone
4 participants
@ryandesign @macportsbot @pmetzger @herbygillot