Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl3: Remove version holdback for OS <10.14. #24547

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

openssl3: Remove version holdback for OS <10.14. #24547

wants to merge 2 commits into from
+34 −26

Conversation

fhgwright
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on
Mac OS X 10.4.11 8S165, PPC, Xcode 2.5 8M2558
Mac OS X 10.4.11 8S2167, i386, Xcode 2.5 8M2558
Mac OS X 10.5.8 9L31a, PPC, Xcode 3.1.4 9M2809
Mac OS X 10.5.8 9L31a, i386, Xcode 3.1.4 9M2809
Mac OS X 10.5.8 9L31a, x86_64, Xcode 3.1.4 9M2809
Mac OS X 10.5.8 9L31a, PPC (i386 Rosetta), Xcode 3.1.4 9M2809
Mac OS X 10.6.8 10K549, i386, Xcode 3.2.6 10M2518
Mac OS X 10.6.8 10K549, x86_64, Xcode 3.2.6 10M2518
Mac OS X 10.6.8 10K549, PPC (i386 Rosetta), Xcode 3.2.6 10M2518
Mac OS X 10.7.5 11G63, x86_64, Xcode 4.6.3 4H1503
OS X 10.8.5 12F2560, x86_64, Xcode 5.1.1 5B1008
OS X 10.9.5 13F1911, x86_64, Xcode 6.2 6C131e
OS X 10.10.5 14F2511, x86_64, Xcode 7.2 7C68
OS X 10.11.6 15G22010, x86_64, Xcode 8.1 8B62
macOS 10.12.6 16G2136, x86_64, Xcode 9.2 9C40b
macOS 10.13.6 17G14042, x86_64, Xcode 10.1 10B61
macOS 10.14.6 18G9323, x86_64, Xcode 11.3.1 11C505
macOS 10.15.7 19H15, x86_64, Xcode 12.4 12D4e
macOS 11.7.10 20G1427, x86_64, Xcode 13.2.1 13C100
macOS 11.7.10 20G1427, arm64, Xcode 13.2.1 13C100
macOS 12.7.5 21H1222, x86_64, Xcode 14.2 14C18
macOS 12.7.5 21H1222, arm64, Xcode 14.2 14C18
macOS 13.6.7 22G720, arm64, Xcode 15.2 15C500b
macOS 14.5 23F79, arm64, Xcode 15.4 15F31d
Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@fhgwright
openssl3: Remove version holdback for OS <10.14.
f9ef4a5 
See: https://trac.macports.org/ticket/68766

Also fixes the build on 10.4.  See the Portfile comments for more
details.  Because this slightly changes the build, it gets a revbump.

TESTED:
Tested on 10.4-10.5 ppc, 10.5-10.6 ppc (i386 Rosetta), 10.4-10.6 i386,
10.5-12.x x86_64, and 11.x-14.x arm64.
Builds on all tested platforms except 10.4 ppc +universal, including
running three simple programs to check that the old 3.2.0+ bug is not
present.
One test fails on 10.5 i386 +universal, in a bizarre way that doesn't
appear to be an issue with OpenSSL itself.  The test framework fails
on 10.6-10.8 due to apparent Perl issues.  All other buildable cases
pass all tests, albeit with some intermittent failures and/or hangs on
10.4-10.12 x86.
@fhgwright
openssl3 picky dependents: required revbumps
8e8f3fc 
This revbumps the four ports that require it on every update to
openssl3, as noted in the Portfile comment.

TESTED:
Did quick builds of the four ports on 10.9, with the new openssl3.
@macportsbot
Copy link

Notifying maintainers:
@larryv for port openssl, openssl3.
@artkiver for port openssh.
@neverpanic for port openssl, openssl3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larryv larryv

@neverpanic neverpanic

Labels
maintainer: requires approval type: enhancement
Milestone
No milestone
4 participants
@fhgwright @macportsbot @larryv @neverpanic