Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tDOM: update to 0.9.1 #2467

Merged
merged 1 commit into from Aug 29, 2018
Merged

tDOM: update to 0.9.1 #2467

merged 1 commit into from Aug 29, 2018

Conversation

kurthindenburg
Copy link
Contributor

Move to tdom.org since github repo has not been updated in years

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.x
Xcode 8.x

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

Move to tdom.org since github repo has not been updated in years
@macportsbot
Copy link

Travis Build #3374 Passed.

Lint results
--->  Verifying Portfile for tDOM
--->  0 errors and 0 warnings found.

Port tDOM success on xcode8.3. Log
Port tDOM success on xcode7.3. Log

@kurthindenburg
Copy link
Contributor Author

I likely should do a maintainer abandonment for this and his other ports.

@pmetzger
Copy link
Member

I likely should do a maintainer abandonment for this and his other ports.

You mean wu.ac.at:neumann?

@pmetzger
Copy link
Member

Anyway, LGTM, we have to wait the three days though.

@kurthindenburg
Copy link
Contributor Author

Yes, I didn't see any recent activity from the maintainer.

@pmetzger
Copy link
Member

@kurthindenburg You should also file an abandonment ticket.

@kurthindenburg
Copy link
Contributor Author

already done in https://trac.macports.org/ticket/57057

Copy link
Contributor

@gustafn gustafn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pushing this forward. A potential variant might be to use the gumbo lib.

@kurthindenburg kurthindenburg merged commit 796771c into master Aug 29, 2018
@kurthindenburg kurthindenburg deleted the tdom-update branch August 29, 2018 12:26
@gustafn
Copy link
Contributor

gustafn commented Aug 29, 2018

interestingly, the updated port builds fine locally, but not by the build-bots (see e.g.
https://build.macports.org/builders/ports-10.13_x86_64-builder/builds/33435/steps/install-port/logs/stdio) It seems that it does not find the "configure" file, although this is included in the .tgz file. Is this a hickup with the built-bot, or is some magic missing to make this work?

@kurthindenburg
Copy link
Contributor Author

I vaguely recall something about the buildbots are on case-sensitive filesystems.

On my local systems the folder is tdom-0.9.1, on buildbot tDOM-0.9.1

I don't know how to resolve ATM

@gustafn
Copy link
Contributor

gustafn commented Aug 29, 2018

interesting!
maybe:
worksrcdir tdom-${version}

The upstream tar files is nowadays just lower case.

@kurthindenburg
Copy link
Contributor Author

Thanks for the note, I forget to check the build bots at times. It looks like it worked.

https://build.macports.org/builders/ports-10.13_x86_64-watcher/builds/8583

@pmetzger
Copy link
Member

Can we get the maintainers line for this port updated?

@kurthindenburg
Copy link
Contributor Author

Is neumann@wu.ac.at still valid for you? I can add gustafn and openmaintainer to the 3 ports if that's fine with you.

@gustafn
Copy link
Contributor

gustafn commented Aug 30, 2018

yes, this email address is still working. no objection for openmaintainer for the three ports.
So far i have not made any updates for the "new" github infrastructure, have not looked at the new procedures in detail ... but i will do so soon, since nsf 2.2 is ante portas...

greetings from greece (vacation).

@pmetzger
Copy link
Member

@kurthindenburg Could you do pull requests for those changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants