Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxgtk-3.0: accept '-stdlib=' option #2513

Merged
merged 1 commit into from Sep 5, 2018
Merged

Conversation

mojca
Copy link
Member

@mojca mojca commented Sep 4, 2018

Description

For details see https://trac.macports.org/ticket/57092

I would prefer if someone else (like @kencu) would check and test this patch first. I also asked @vslavik to try to fix it upstream (I wasn't sure where upstream of this file was), once that is done, we need an upstream fix in wxWidgets as well.

We probably also need to fix wxgtk-3.2 and fix dependency on webkit-gtk (either always disable or always enable it) as a separate task.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.x
Xcode 8.x

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@mojca mojca requested a review from kencu September 4, 2018 08:25
@macportsbot macportsbot added by: member Created by a member with commit rights type: bugfix labels Sep 4, 2018
@kencu
Copy link
Contributor

kencu commented Sep 4, 2018

will test today

Copy link
Contributor

@kencu kencu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfectly on this system. Looks good!

@mojca
Copy link
Member Author

mojca commented Sep 5, 2018

Thank you.

@mojca mojca merged commit 49a46bc into macports:master Sep 5, 2018
@mojca mojca deleted the wxgtk-stdlib branch September 5, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights type: bugfix
3 participants